Drop support for older browsers (#2918)

Older browsers can still be supported through transpilation and polyfills
graphql · Feb 15, 2021 · 0e52e54 · 0e52e54
1 parent 31e8484
commit 0e52e54
Show file tree

Hide file tree

Showing 8 changed files with 38 additions and 61 deletions.
diff --git a/.babelrc-deno.json b/.babelrc-deno.json
@@ -3,11 +3,5 @@
     "@babel/plugin-transform-flow-strip-types",
     ["./resources/add-extension-to-import-paths", { "extension": "js" }],
     "./resources/inline-invariant"
-  ],
-  "overrides": [
-    {
-      "include": "src/error/GraphQLError.js",
-      "plugins": [["@babel/plugin-transform-classes", { "loose": false }]]
-    }
   ]
 }
diff --git a/.babelrc-npm.json b/.babelrc-npm.json
@@ -0,0 +1,27 @@
+{
+  "plugins": [
+    "@babel/plugin-transform-flow-strip-types",
+    "./resources/inline-invariant"
+  ],
+  "env": {
+    "cjs": {
+      "presets": [
+        [
+          "@babel/preset-env",
+          { "modules": "commonjs", "targets": { "node": "10" } }
+        ]
+      ],
+      "plugins": [
+        ["./resources/add-extension-to-import-paths", { "extension": "js" }]
+      ]
+    },
+    "mjs": {
+      "presets": [
+        ["@babel/preset-env", { "modules": false, "targets": { "node": "10" } }]
+      ],
+      "plugins": [
+        ["./resources/add-extension-to-import-paths", { "extension": "mjs" }]
+      ]
+    }
+  }
+}
diff --git a/.babelrc.json b/.babelrc.json
@@ -1,42 +1,4 @@
 {
-  "presets": [["@babel/preset-env", { "targets": { "node": "current" } }]],
   "plugins": ["@babel/plugin-transform-flow-strip-types"],
-  "overrides": [
-    {
-      "exclude": ["src/__testUtils__/**/*", "**/__tests__/**/*"],
-      "presets": ["@babel/preset-env"],
-      "plugins": [
-        ["@babel/plugin-transform-classes", { "loose": true }],
-        ["@babel/plugin-transform-destructuring", { "loose": true }],
-        ["@babel/plugin-transform-spread", { "loose": true }],
-        ["@babel/plugin-transform-for-of", { "assumeArray": true }]
-      ],
-      "env": {
-        "cjs": {
-          "presets": [["@babel/preset-env", { "modules": "commonjs" }]],
-          "plugins": [
-            [
-              "./resources/add-extension-to-import-paths",
-              { "extension": "js" }
-            ],
-            "./resources/inline-invariant"
-          ]
-        },
-        "mjs": {
-          "presets": [["@babel/preset-env", { "modules": false }]],
-          "plugins": [
-            [
-              "./resources/add-extension-to-import-paths",
-              { "extension": "mjs" }
-            ],
-            "./resources/inline-invariant"
-          ]
-        }
-      }
-    },
-    {
-      "include": "src/error/GraphQLError.js",
-      "plugins": [["@babel/plugin-transform-classes", { "loose": false }]]
-    }
-  ]
+  "presets": [["@babel/preset-env", { "targets": { "node": "current" } }]]
 }
diff --git a/.browserslistrc b/.browserslistrc
diff --git a/.eslintrc.yml b/.eslintrc.yml
@@ -51,8 +51,8 @@ rules:
   node/no-unpublished-import: error
   node/no-unpublished-require: error
   node/no-unsupported-features/es-builtins: error
-  node/no-unsupported-features/es-syntax: off # TODO enable
-  node/no-unsupported-features/node-builtins: off # TODO enable
+  node/no-unsupported-features/es-syntax: [error, { ignores: [modules] }]
+  node/no-unsupported-features/node-builtins: error
   node/process-exit-as-throw: error
   node/shebang: error
 

diff --git a/package.json b/package.json
@@ -21,9 +21,6 @@
     "graphql-js"
   ],
   "engines": {
-    "node": ">= 14.2"
-  },
-  "engines_on_npm": {
     "node": ">= 10.x"
   },
   "scripts": {

diff --git a/resources/build-npm.js b/resources/build-npm.js
@@ -46,7 +46,12 @@ if (require.main === module) {
 }
 
 function babelBuild(srcPath, options) {
-  return babel.transformFileSync(srcPath, options).code + '\n';
+  const { code } = babel.transformFileSync(srcPath, {
+    babelrc: false,
+    configFile: './.babelrc-npm.json',
+    ...options,
+  });
+  return code + '\n';
 }
 
 function buildPackageJSON() {
@@ -55,9 +60,6 @@ function buildPackageJSON() {
   delete packageJSON.scripts;
   delete packageJSON.devDependencies;
 
-  packageJSON.engines = packageJSON.engines_on_npm;
-  delete packageJSON.engines_on_npm;
-
   const { version } = packageJSON;
   const versionMatch = /^\d+\.\d+\.\d+-?(?<preReleaseTag>.*)?$/.exec(version);
   if (!versionMatch) {

diff --git a/tsconfig.json b/tsconfig.json
@@ -2,7 +2,8 @@
   "exclude": ["integrationTests/ts/**/*"],
   "compilerOptions": {
     "module": "commonjs",
-    "lib": ["es6", "esnext.asynciterable"],
+    "lib": ["es2018"],
+    "target": "es2018",
     "noImplicitAny": true,
     "noImplicitThis": true,
     "strictNullChecks": true,