mapAsyncIterator: add default value for 'rejectCallback' (#3011)

graphql · Apr 1, 2021 · 5ed55b8 · 5ed55b8
1 parent ecf732f
commit 5ed55b8
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/src/subscription/mapAsyncIterator.js b/src/subscription/mapAsyncIterator.js
@@ -7,7 +7,9 @@ import type { PromiseOrValue } from '../jsutils/PromiseOrValue';
 export function mapAsyncIterator<T, U>(
   iterable: AsyncIterable<T> | AsyncGenerator<T, void, void>,
   callback: (T) => PromiseOrValue<U>,
-  rejectCallback?: (any) => PromiseOrValue<U>,
+  rejectCallback: (any) => PromiseOrValue<U> = (error) => {
+    throw error;
+  },
 ): AsyncGenerator<U, void, void> {
   // $FlowFixMe[prop-missing]
   const iteratorMethod = iterable[Symbol.asyncIterator];
@@ -28,12 +30,11 @@ export function mapAsyncIterator<T, U>(
       : asyncMapValue(result.value, callback).then(iteratorResult, abruptClose);
   }
 
-  let mapReject;
-  if (rejectCallback) {
-    // Capture rejectCallback to ensure it cannot be null.
-    const reject = rejectCallback;
-    mapReject = (error: mixed) =>
-      asyncMapValue(error, reject).then(iteratorResult, abruptClose);
+  function mapReject(error: mixed) {
+    return asyncMapValue(error, rejectCallback).then(
+      iteratorResult,
+      abruptClose,
+    );
   }
 
   /* TODO: Flow doesn't support symbols as keys: