ASTVisitor: use type intersection instead of type union (#2959)

graphql · Mar 13, 2021 · 789a98a · 789a98a
1 parent 2c2d87e
commit 789a98a
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 18 deletions.
diff --git a/src/language/visitor.d.ts b/src/language/visitor.d.ts
@@ -6,17 +6,17 @@ import { ASTNode, ASTKindToNode } from './ast';
  * A visitor is provided to visit, it contains the collection of
  * relevant functions to be called during the visitor's traversal.
  */
-export type ASTVisitor = EnterLeave<ASTVisitFn<ASTNode>> | ShapeMapVisitor;
+export type ASTVisitor = EnterLeaveVisitor<ASTNode> & KindVisitor;
 
-interface EnterLeave<T> {
-  readonly enter?: T;
-  readonly leave?: T;
-}
-
-type ShapeMapVisitor = {
-  [K in keyof ASTKindToNode]?:
+type KindVisitor = {
+  readonly [K in keyof ASTKindToNode]?:
     | ASTVisitFn<ASTKindToNode[K]>
-    | EnterLeave<ASTVisitFn<ASTKindToNode[K]>>;
+    | EnterLeaveVisitor<ASTKindToNode[K]>;
+};
+
+type EnterLeaveVisitor<TVisitedNode extends ASTNode> = {
+  readonly enter?: ASTVisitFn<TVisitedNode>;
+  readonly leave?: ASTVisitFn<TVisitedNode>;
 };
 
 /**

diff --git a/src/language/visitor.js b/src/language/visitor.js
@@ -7,14 +7,17 @@ import { isNode } from './ast';
  * A visitor is provided to visit, it contains the collection of
  * relevant functions to be called during the visitor's traversal.
  */
-export type ASTVisitor =
-  | EnterLeave<ASTVisitFn<ASTNode>>
-  | ShapeMap<
-      ASTKindToNode,
-      <Node>(Node) => ASTVisitFn<Node> | EnterLeave<ASTVisitFn<Node>>,
-    >;
-type EnterLeave<T> = {| +enter?: T, +leave?: T |};
-type ShapeMap<O, F> = $Shape<$ObjMap<O, F>>;
+export type ASTVisitor = $Shape<EnterLeaveVisitor<ASTNode> & KindVisitor>;
+
+type KindVisitor = $ObjMap<
+  ASTKindToNode,
+  <Node>(Node) => ASTVisitFn<Node> | EnterLeaveVisitor<Node>,
+>;
+
+type EnterLeaveVisitor<TVisitedNode: ASTNode> = {|
+  +enter?: ASTVisitFn<TVisitedNode>,
+  +leave?: ASTVisitFn<TVisitedNode>,
+|};
 
 /**
  * A visitor is comprised of visit functions, which are called on each node
@@ -389,7 +392,6 @@ export function getVisitFn(
       return kindSpecificVisitor;
     }
   } else {
-    // $FlowFixMe[prop-missing]
     const specificVisitor = isLeaving ? visitor.leave : visitor.enter;
     if (specificVisitor) {
       // { enter() {}, leave() {} }