Improve naming 'err => error' and 'arr => array' (#3073)

graphql · May 10, 2021 · 78d5f83 · 78d5f83
1 parent 3cfb2be
commit 78d5f83
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/src/utilities/lexicographicSortSchema.js b/src/utilities/lexicographicSortSchema.js
@@ -104,8 +104,8 @@ export function lexicographicSortSchema(schema: GraphQLSchema): GraphQLSchema {
     }));
   }
 
-  function sortTypes<T: GraphQLNamedType>(arr: $ReadOnlyArray<T>): Array<T> {
-    return sortByName(arr).map(replaceNamedType);
+  function sortTypes<T: GraphQLNamedType>(array: $ReadOnlyArray<T>): Array<T> {
+    return sortByName(array).map(replaceNamedType);
   }
 
   function sortNamedType(type: GraphQLNamedType): GraphQLNamedType {

diff --git a/src/validation/ValidationContext.d.ts b/src/validation/ValidationContext.d.ts
@@ -35,7 +35,7 @@ interface VariableUsage {
  * validation rule.
  */
 export class ASTValidationContext {
-  constructor(ast: DocumentNode, onError: (err: GraphQLError) => void);
+  constructor(ast: DocumentNode, onError: (error: GraphQLError) => void);
 
   reportError(error: GraphQLError): undefined;
 
@@ -54,7 +54,7 @@ export class SDLValidationContext extends ASTValidationContext {
   constructor(
     ast: DocumentNode,
     schema: Maybe<GraphQLSchema>,
-    onError: (err: GraphQLError) => void,
+    onError: (error: GraphQLError) => void,
   );
 
   getSchema(): Maybe<GraphQLSchema>;
@@ -67,7 +67,7 @@ export class ValidationContext extends ASTValidationContext {
     schema: GraphQLSchema,
     ast: DocumentNode,
     typeInfo: TypeInfo,
-    onError: (err: GraphQLError) => void,
+    onError: (error: GraphQLError) => void,
   );
 
   getSchema(): GraphQLSchema;

diff --git a/src/validation/ValidationContext.js b/src/validation/ValidationContext.js
@@ -42,15 +42,15 @@ type VariableUsage = {|
  */
 export class ASTValidationContext {
   _ast: DocumentNode;
-  _onError: (err: GraphQLError) => void;
+  _onError: (error: GraphQLError) => void;
   _fragments: ?ObjMap<FragmentDefinitionNode>;
   _fragmentSpreads: Map<SelectionSetNode, $ReadOnlyArray<FragmentSpreadNode>>;
   _recursivelyReferencedFragments: Map<
     OperationDefinitionNode,
     $ReadOnlyArray<FragmentDefinitionNode>,
   >;
 
-  constructor(ast: DocumentNode, onError: (err: GraphQLError) => void) {
+  constructor(ast: DocumentNode, onError: (error: GraphQLError) => void) {
     this._ast = ast;
     this._fragments = undefined;
     this._fragmentSpreads = new Map();
@@ -136,7 +136,7 @@ export class SDLValidationContext extends ASTValidationContext {
   constructor(
     ast: DocumentNode,
     schema: ?GraphQLSchema,
-    onError: (err: GraphQLError) => void,
+    onError: (error: GraphQLError) => void,
   ) {
     super(ast, onError);
     this._schema = schema;
@@ -162,7 +162,7 @@ export class ValidationContext extends ASTValidationContext {
     schema: GraphQLSchema,
     ast: DocumentNode,
     typeInfo: TypeInfo,
-    onError: (err: GraphQLError) => void,
+    onError: (error: GraphQLError) => void,
   ) {
     super(ast, onError);
     this._schema = schema;

diff --git a/src/validation/__tests__/validation-test.js b/src/validation/__tests__/validation-test.js
@@ -71,7 +71,7 @@ describe('Validate: Supports full validation', () => {
     `);
 
     const errors = validate(testSchema, doc, undefined, undefined, typeInfo);
-    const errorMessages = errors.map((err) => err.message);
+    const errorMessages = errors.map((error) => error.message);
 
     expect(errorMessages).to.deep.equal([
       'Cannot query field "catOrDog" on type "QueryRoot". Did you mean "catOrDog"?',