invariant: improve code that babel outputs (#2064)

graphql · Jul 30, 2019 · 91a4be2 · 91a4be2
1 parent dea6028
commit 91a4be2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/resources/inline-invariant.js b/resources/inline-invariant.js
@@ -15,9 +15,7 @@
  */
 module.exports = function inlineInvariant(context) {
   const replaceTemplate = context.template(`
-    if (!%%cond%%) {
-      invariant(0, %%args%%);
-    }
+    (%%cond%%) || invariant(0, %%args%%)
   `);
 
   return {
@@ -39,9 +37,9 @@ module.exports = function inlineInvariant(context) {
 
 function isAppropriateInvariantCall(node, parent) {
   return (
+    parent.type === 'ExpressionStatement' &&
     node.callee.type === 'Identifier' &&
     node.callee.name === 'invariant' &&
-    node.arguments.length > 0 &&
-    parent.type === 'ExpressionStatement'
+    node.arguments.length > 0
   );
 }
diff --git a/src/jsutils/invariant.js b/src/jsutils/invariant.js
@@ -1,9 +1,9 @@
 // @flow strict
 
-export default function invariant(condition: mixed, message: string) {
+/* istanbul ignore file */
+export default function invariant(condition: mixed, message?: string): void {
   const booleanCondition = Boolean(condition);
-  /* istanbul ignore else */
   if (!booleanCondition) {
-    throw new Error(message);
+    throw new Error(message || 'Unexpected invariant triggered');
   }
 }