Switch some of arguments from Array to $ReadOnlyArray (#2001)

graphql · Jun 28, 2019 · 9b2e626 · 9b2e626
1 parent 27f695e
commit 9b2e626
Show file tree

Hide file tree

Showing 13 changed files with 18 additions and 16 deletions.
diff --git a/src/execution/values.js b/src/execution/values.js
@@ -40,7 +40,7 @@ type CoercedVariableValues = {|
  */
 export function getVariableValues(
   schema: GraphQLSchema,
-  varDefNodes: Array<VariableDefinitionNode>,
+  varDefNodes: $ReadOnlyArray<VariableDefinitionNode>,
   inputs: ObjMap<mixed>,
 ): CoercedVariableValues {
   const errors = [];

diff --git a/src/jsutils/dedent.js b/src/jsutils/dedent.js
@@ -13,8 +13,8 @@
  * str === "{\n  test\n}\n";
  */
 export default function dedent(
-  strings: Array<string>,
-  ...values: Array<string>
+  strings: $ReadOnlyArray<string>,
+  ...values: $ReadOnlyArray<string>
 ): string {
   let str = '';
 

diff --git a/src/language/blockString.js b/src/language/blockString.js
@@ -32,7 +32,9 @@ export function dedentBlockStringValue(rawString: string): string {
 }
 
 // @internal
-export function getBlockStringIndentation(lines: Array<string>): number {
+export function getBlockStringIndentation(
+  lines: $ReadOnlyArray<string>,
+): number {
   let commonIndent = null;
 
   for (let i = 1; i < lines.length; i++) {

diff --git a/src/language/printLocation.js b/src/language/printLocation.js
@@ -67,7 +67,7 @@ export function printSourceLocation(
   );
 }
 
-function printPrefixedLines(lines: Array<[string, string]>): string {
+function printPrefixedLines(lines: $ReadOnlyArray<[string, string]>): string {
   const existingLines = lines.filter(([_, line]) => line !== undefined);
 
   const padLen = Math.max(...existingLines.map(([prefix]) => prefix.length));

diff --git a/src/language/visitor.js b/src/language/visitor.js
@@ -354,7 +354,7 @@ function isNode(maybeNode): boolean %checks {
  * If a prior visitor edits a node, no following visitors will see that node.
  */
 export function visitInParallel(
-  visitors: Array<Visitor<ASTKindToNode>>,
+  visitors: $ReadOnlyArray<Visitor<ASTKindToNode>>,
 ): Visitor<ASTKindToNode> {
   const skipping = new Array(visitors.length);
 

diff --git a/src/type/definition.js b/src/type/definition.js
@@ -803,7 +803,7 @@ function fieldsToFieldsConfig(fields) {
 }
 
 export function argsToArgsConfig(
-  args: Array<GraphQLArgument>,
+  args: $ReadOnlyArray<GraphQLArgument>,
 ): GraphQLFieldConfigArgumentMap {
   return keyValMap(
     args,

diff --git a/src/utilities/lexicographicSortSchema.js b/src/utilities/lexicographicSortSchema.js
@@ -94,7 +94,7 @@ export function lexicographicSortSchema(schema: GraphQLSchema): GraphQLSchema {
     }));
   }
 
-  function sortTypes<T: GraphQLNamedType>(arr: Array<T>): Array<T> {
+  function sortTypes<T: GraphQLNamedType>(arr: $ReadOnlyArray<T>): Array<T> {
     return sortByName(arr).map(replaceNamedType);
   }
 

diff --git a/src/validation/rules/FieldsOnCorrectType.js b/src/validation/rules/FieldsOnCorrectType.js
@@ -17,8 +17,8 @@ import {
 export function undefinedFieldMessage(
   fieldName: string,
   type: string,
-  suggestedTypeNames: Array<string>,
-  suggestedFieldNames: Array<string>,
+  suggestedTypeNames: $ReadOnlyArray<string>,
+  suggestedFieldNames: $ReadOnlyArray<string>,
 ): string {
   const quotedTypeNames = suggestedTypeNames.map(x => `"${x}"`);
   const quotedFieldNames = suggestedFieldNames.map(x => `"${x}"`);

diff --git a/src/validation/rules/KnownArgumentNames.js b/src/validation/rules/KnownArgumentNames.js
@@ -15,7 +15,7 @@ export function unknownArgMessage(
   argName: string,
   fieldName: string,
   typeName: string,
-  suggestedArgs: Array<string>,
+  suggestedArgs: $ReadOnlyArray<string>,
 ): string {
   return (
     `Unknown argument "${argName}" on field "${fieldName}" of type "${typeName}".` +
@@ -26,7 +26,7 @@ export function unknownArgMessage(
 export function unknownDirectiveArgMessage(
   argName: string,
   directiveName: string,
-  suggestedArgs: Array<string>,
+  suggestedArgs: $ReadOnlyArray<string>,
 ): string {
   return (
     `Unknown argument "${argName}" on directive "@${directiveName}".` +

diff --git a/src/validation/rules/KnownTypeNames.js b/src/validation/rules/KnownTypeNames.js
@@ -18,7 +18,7 @@ import { specifiedScalarTypes } from '../../type/scalars';
 
 export function unknownTypeMessage(
   typeName: string,
-  suggestedTypes: Array<string>,
+  suggestedTypes: $ReadOnlyArray<string>,
 ): string {
   return (
     `Unknown type "${typeName}".` +

diff --git a/src/validation/rules/NoFragmentCycles.js b/src/validation/rules/NoFragmentCycles.js
@@ -7,7 +7,7 @@ import { type ASTVisitor } from '../../language/visitor';
 
 export function cycleErrorMessage(
   fragName: string,
-  spreadNames: Array<string>,
+  spreadNames: $ReadOnlyArray<string>,
 ): string {
   const via = spreadNames.length ? ' via ' + spreadNames.join(', ') : '';
   return `Cannot spread fragment "${fragName}" within itself${via}.`;

diff --git a/src/validation/rules/OverlappingFieldsCanBeMerged.js b/src/validation/rules/OverlappingFieldsCanBeMerged.js
@@ -779,7 +779,7 @@ function _collectFieldsAndFragmentNames(
 // Given a series of Conflicts which occurred between two sub-fields, generate
 // a single Conflict.
 function subfieldConflicts(
-  conflicts: Array<Conflict>,
+  conflicts: $ReadOnlyArray<Conflict>,
   responseName: string,
   node1: FieldNode,
   node2: FieldNode,

diff --git a/src/validation/rules/PossibleTypeExtensions.js b/src/validation/rules/PossibleTypeExtensions.js
@@ -18,7 +18,7 @@ import {
 
 export function extendingUnknownTypeMessage(
   typeName: string,
-  suggestedTypes: Array<string>,
+  suggestedTypes: $ReadOnlyArray<string>,
 ): string {
   return (
     `Cannot extend type "${typeName}" because it is not defined.` +