Appease codecoverage

graphql · May 27, 2021 · 9f718b8 · 9f718b8
1 parent 9a69bb1
commit 9f718b8
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 20 deletions.
diff --git a/src/validation/__tests__/SingleFieldSubscriptionsRule-test.ts b/src/validation/__tests__/SingleFieldSubscriptionsRule-test.ts
@@ -2,7 +2,11 @@ import { describe, it } from 'mocha';
 
 import { SingleFieldSubscriptionsRule } from '../rules/SingleFieldSubscriptionsRule';
 
-import { expectValidationErrors } from './harness';
+import {
+  expectValidationErrors,
+  expectValidationErrorsWithSchema,
+  emptySchema,
+} from './harness';
 
 function expectErrors(queryStr: string) {
   return expectValidationErrors(SingleFieldSubscriptionsRule, queryStr);
@@ -254,4 +258,16 @@ describe('Validate: Subscriptions with single field', () => {
       },
     ]);
   });
+
+  it('skips if not subscription type', () => {
+    expectValidationErrorsWithSchema(
+      emptySchema,
+      SingleFieldSubscriptionsRule,
+      `
+        subscription {
+          __typename
+        }
+      `,
+    ).to.deep.equal([]);
+  });
 });
diff --git a/src/validation/__tests__/harness.ts b/src/validation/__tests__/harness.ts
@@ -159,6 +159,16 @@ export const testSchema: GraphQLSchema = buildSchema(`
   directive @onVariableDefinition on VARIABLE_DEFINITION
 `);
 
+export const emptySchema: GraphQLSchema = buildSchema(`
+  type QueryRoot {
+    empty: Boolean
+  }
+
+  schema {
+    query: QueryRoot
+  }
+`);
+
 export function expectValidationErrorsWithSchema(
   schema: GraphQLSchema,
   rule: ValidationRule,

diff --git a/src/validation/rules/SingleFieldSubscriptionsRule.ts b/src/validation/rules/SingleFieldSubscriptionsRule.ts
@@ -10,11 +10,11 @@ import { Kind } from '../../language/kinds';
 
 import type { ValidationContext } from '../ValidationContext';
 import type { ExecutionContext } from '../../execution/execute';
-import { collectFields } from '../../execution/execute';
-
-function fakeResolver() {
-  /* noop */
-}
+import {
+  collectFields,
+  defaultFieldResolver,
+  defaultTypeResolver,
+} from '../../execution/execute';
 
 /**
  * Subscriptions must only include a non-introspection field.
@@ -50,8 +50,8 @@ export function SingleFieldSubscriptionsRule(
             contextValue: undefined,
             operation: node,
             variableValues,
-            fieldResolver: fakeResolver,
-            typeResolver: fakeResolver,
+            fieldResolver: defaultFieldResolver,
+            typeResolver: defaultTypeResolver,
             errors: [],
           };
           const fields = collectFields(
@@ -78,18 +78,16 @@ export function SingleFieldSubscriptionsRule(
           }
           for (const responseKey of Object.keys(fields)) {
             const field = fields[responseKey][0];
-            if (field) {
-              const fieldName = field.name.value;
-              if (fieldName[0] === '_' && fieldName[1] === '_') {
-                context.reportError(
-                  new GraphQLError(
-                    operationName != null
-                      ? `Subscription "${operationName}" must not select an introspection top level field.`
-                      : 'Anonymous Subscription must not select an introspection top level field.',
-                    fields[responseKey],
-                  ),
-                );
-              }
+            const fieldName = field.name.value;
+            if (fieldName[0] === '_' && fieldName[1] === '_') {
+              context.reportError(
+                new GraphQLError(
+                  operationName != null
+                    ? `Subscription "${operationName}" must not select an introspection top level field.`
+                    : 'Anonymous Subscription must not select an introspection top level field.',
+                  fields[responseKey],
+                ),
+              );
             }
           }
         }