BREAKING: Disallow "true", "false", and "null" as enum values

The specification disallows these in the SDL grammar definition, and using one of these enum values would result in a schema that would throw validation errors on creation.

Fixes #3221.

src/language/__tests__/parser-test.ts

@@ -120,6 +120,13 @@ describe('Parser', () => {
     });
   });
 
+  it('does not allow "true" as enum value', () => {
+    expectSyntaxError('enum Test { VALID, true }').to.deep.equal({
+      message: 'Syntax Error: Name "true" is not a valid enum value.',
+      locations: [{ line: 1, column: 20 }],
+    });
+  });
+
   it('parses multi-byte characters', () => {
     // Note: \u0A0A could be naively interpreted as two line-feed chars.
     const ast = parse(`

src/language/ast.ts

@@ -584,7 +584,7 @@ export interface EnumValueDefinitionNode {
   readonly kind: 'EnumValueDefinition';
   readonly loc?: Location;
   readonly description?: StringValueNode;
-  readonly name: NameNode;
+  readonly name: EnumValueNode;
   readonly directives?: ReadonlyArray<ConstDirectiveNode>;
 }
 

src/language/parser.ts

@@ -1036,13 +1036,11 @@ export class Parser {
 
   /**
    * EnumValueDefinition : Description? EnumValue Directives[Const]?
-   *
-   * EnumValue : Name
    */
   parseEnumValueDefinition(): EnumValueDefinitionNode {
     const start = this._lexer.token;
     const description = this.parseDescription();
-    const name = this.parseName();
+    const name = this.parseEnumValue();
     const directives = this.parseConstDirectives();
     return this.node<EnumValueDefinitionNode>(start, {
       kind: Kind.ENUM_VALUE_DEFINITION,
@@ -1052,6 +1050,25 @@ export class Parser {
     });
   }
 
+  /**
+   * EnumValue : Name but not `true`, `false` or `null`
+   */
+  parseEnumValue(): EnumValueNode {
+    const node = this.parseName();
+    if (node.value === 'true' || node.value === 'false' || node.value === 'null') {
+      throw syntaxError(
+        this._lexer.source,
+        this._lexer.lastToken.start,
+        `${getTokenDesc(this._lexer.lastToken)} is not a valid enum value.`,
+      );
+    }
+    return {
+      kind: 'EnumValue',
+      value: node.value,
+      loc: node.loc
+    };
+  }
+
   /**
    * InputObjectTypeDefinition :
    *   - Description? input Name Directives[Const]? InputFieldsDefinition?