Simplify code by replacing Object.entries with Object.keys (#3406)

graphql · Dec 4, 2021 · c145cd4 · c145cd4
1 parent 947165f
commit c145cd4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/jsutils/mapValue.ts b/src/jsutils/mapValue.ts
@@ -10,8 +10,8 @@ export function mapValue<T, V>(
 ): ObjMap<V> {
   const result = Object.create(null);
 
-  for (const [key, value] of Object.entries(map)) {
-    result[key] = fn(value, key);
+  for (const key of Object.keys(map)) {
+    result[key] = fn(map[key], key);
   }
   return result;
 }
diff --git a/src/utilities/lexicographicSortSchema.ts b/src/utilities/lexicographicSortSchema.ts
@@ -166,9 +166,8 @@ function sortObjMap<T, R>(
   sortValueFn: (value: T) => R,
 ): ObjMap<R> {
   const sortedMap = Object.create(null);
-  const sortedEntries = sortBy(Object.entries(map), ([key]) => key);
-  for (const [key, value] of sortedEntries) {
-    sortedMap[key] = sortValueFn(value);
+  for (const key of Object.keys(map).sort(naturalCompare)) {
+    sortedMap[key] = sortValueFn(map[key]);
   }
   return sortedMap;
 }