flow: Improve typings for exported definitions (#2992)

graphql · Mar 26, 2021 · c52b595 · c52b595
1 parent d720b5b
commit c52b595
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 18 deletions.
diff --git a/src/validation/__tests__/harness.js b/src/validation/__tests__/harness.js
@@ -9,7 +9,7 @@ import { buildSchema } from '../../utilities/buildASTSchema';
 import { validate, validateSDL } from '../validate';
 import type { ValidationRule, SDLValidationRule } from '../ValidationContext';
 
-export const testSchema = buildSchema(`
+export const testSchema: GraphQLSchema = buildSchema(`
   interface Being {
     name(surname: Boolean): String
   }

diff --git a/src/validation/specifiedRules.js b/src/validation/specifiedRules.js
@@ -1,3 +1,5 @@
+import type { ValidationRule, SDLValidationRule } from './ValidationContext';
+
 // Spec Section: "Executable Definitions"
 import { ExecutableDefinitionsRule } from './rules/ExecutableDefinitionsRule';
 
@@ -97,7 +99,7 @@ import { PossibleTypeExtensionsRule } from './rules/PossibleTypeExtensionsRule';
  * The order of the rules in this list has been adjusted to lead to the
  * most clear output when encountering multiple validation errors.
  */
-export const specifiedRules = Object.freeze([
+export const specifiedRules: $ReadOnlyArray<ValidationRule> = Object.freeze([
   ExecutableDefinitionsRule,
   UniqueOperationNamesRule,
   LoneAnonymousOperationRule,
@@ -129,19 +131,21 @@ export const specifiedRules = Object.freeze([
 /**
  * @internal
  */
-export const specifiedSDLRules = Object.freeze([
-  LoneSchemaDefinitionRule,
-  UniqueOperationTypesRule,
-  UniqueTypeNamesRule,
-  UniqueEnumValueNamesRule,
-  UniqueFieldDefinitionNamesRule,
-  UniqueDirectiveNamesRule,
-  KnownTypeNamesRule,
-  KnownDirectivesRule,
-  UniqueDirectivesPerLocationRule,
-  PossibleTypeExtensionsRule,
-  KnownArgumentNamesOnDirectivesRule,
-  UniqueArgumentNamesRule,
-  UniqueInputFieldNamesRule,
-  ProvidedRequiredArgumentsOnDirectivesRule,
-]);
+export const specifiedSDLRules: $ReadOnlyArray<SDLValidationRule> = Object.freeze(
+  [
+    LoneSchemaDefinitionRule,
+    UniqueOperationTypesRule,
+    UniqueTypeNamesRule,
+    UniqueEnumValueNamesRule,
+    UniqueFieldDefinitionNamesRule,
+    UniqueDirectiveNamesRule,
+    KnownTypeNamesRule,
+    KnownDirectivesRule,
+    UniqueDirectivesPerLocationRule,
+    PossibleTypeExtensionsRule,
+    KnownArgumentNamesOnDirectivesRule,
+    UniqueArgumentNamesRule,
+    UniqueInputFieldNamesRule,
+    ProvidedRequiredArgumentsOnDirectivesRule,
+  ],
+);