findBreakingChanges: extract 'findByName' utility function (#1901)

graphql · May 24, 2019 · c906b7c · c906b7c
1 parent d414076
commit c906b7c
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/utilities/findBreakingChanges.js b/src/utilities/findBreakingChanges.js
@@ -206,7 +206,7 @@ function findArgChanges(
 
       for (const oldArgDef of oldTypeFields[fieldName].args) {
         const newArgs = newTypeFields[fieldName].args;
-        const newArgDef = find(newArgs, arg => arg.name === oldArgDef.name);
+        const newArgDef = findByName(newArgs, oldArgDef.name);
 
         // Arg not present
         if (!newArgDef) {
@@ -245,7 +245,7 @@ function findArgChanges(
       // Check if arg was added to the field
       for (const newArgDef of newTypeFields[fieldName].args) {
         const oldArgs = oldTypeFields[fieldName].args;
-        const oldArgDef = find(oldArgs, arg => arg.name === newArgDef.name);
+        const oldArgDef = findByName(oldArgs, newArgDef.name);
         if (!oldArgDef) {
           const argName = newArgDef.name;
           if (isRequiredArgument(newArgDef)) {
@@ -854,3 +854,7 @@ function getArgumentMapForDirective(
 ): ObjMap<GraphQLArgument> {
   return keyMap(directive.args, arg => arg.name);
 }
+
+function findByName(array, name) {
+  return find(array, item => item.name === name);
+}