Update Flow (#2658)

.flowconfig

@@ -35,8 +35,6 @@ include_warnings=true
 module.use_strict=true
 babel_loose_array_spread=true
 esproposal.optional_chaining=enable
-suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(<VERSION>\\)?)\\)
-suppress_comment=\\(.\\|\n\\)*\\$DisableFlowOnNegativeTest
 
 [version]
-^0.126.0
+^0.127.0

package.json

@@ -64,7 +64,7 @@
     "eslint-plugin-internal-rules": "file:./resources/eslint-internal-rules",
     "eslint-plugin-istanbul": "0.1.1",
     "eslint-plugin-node": "11.1.0",
-    "flow-bin": "0.126.1",
+    "flow-bin": "0.127.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "prettier": "2.0.5",

src/error/__tests__/formatError-test.js

@@ -8,7 +8,7 @@ import { GraphQLError } from '../GraphQLError';
 
 describe('formatError: default error formatter', () => {
   it('uses default message', () => {
-    // $DisableFlowOnNegativeTest
+    // $FlowExpectedError
     const e = new GraphQLError();
 
     expect(formatError(e)).to.deep.equal({
@@ -47,12 +47,12 @@ describe('formatError: default error formatter', () => {
   });
 
   it('rejects null and undefined errors', () => {
-    // $DisableFlowOnNegativeTest
+    // $FlowExpectedError
     expect(() => formatError(undefined)).to.throw(
       'Received null or undefined error.',
     );
 
-    // $DisableFlowOnNegativeTest
+    // $FlowExpectedError
     expect(() => formatError(null)).to.throw(
       'Received null or undefined error.',
     );

src/execution/__tests__/abstract-test.js

@@ -405,7 +405,7 @@ describe('Execute: Handles execution of abstract types', () => {
     const fooInterface = new GraphQLInterfaceType({
       name: 'FooInterface',
       fields: { bar: { type: GraphQLString } },
-      // $DisableFlowOnNegativeTest
+      // $FlowExpectedError
       resolveType() {
         return [];
       },

src/execution/__tests__/executor-test.js

@@ -32,14 +32,14 @@ describe('Execute: Handles basic execution tasks', () => {
       }),
     });
 
-    // $DisableFlowOnNegativeTest
+    // $FlowExpectedError
     expect(() => execute({ schema })).to.throw('Must provide document.');
   });
 
   it('throws if no schema is provided', () => {
     const document = parse('{ field }');
 
-    // $DisableFlowOnNegativeTest
+    // $FlowExpectedError
     expect(() => execute({ document })).to.throw(
       'Expected undefined to be a GraphQL schema.',
     );
@@ -64,7 +64,7 @@ describe('Execute: Handles basic execution tasks', () => {
     `);
     const variableValues = '{ "a": 1 }';
 
-    // $DisableFlowOnNegativeTest
+    // $FlowExpectedError
     expect(() => execute({ schema, document, variableValues })).to.throw(
       'Variables must be provided as an Object where each property is a variable value. Perhaps look to see if an unparsed JSON string was provided.',
     );

src/language/__tests__/parser-test.js

@@ -24,12 +24,12 @@ function expectSyntaxError(text) {
 
 describe('Parser', () => {
   it('asserts that a source to parse was provided', () => {
-    // $DisableFlowOnNegativeTest
+    // $FlowExpectedError
     expect(() => parse()).to.throw('Must provide Source. Received: undefined.');
   });
 
   it('asserts that an invalid source to parse was provided', () => {
-    // $DisableFlowOnNegativeTest
+    // $FlowExpectedError
     expect(() => parse({})).to.throw('Must provide Source. Received: {}.');
   });
 

src/language/__tests__/printer-test.js

@@ -25,7 +25,8 @@ describe('Printer: Query document', () => {
 
   it('produces helpful error messages', () => {
     const badAST = { random: 'Data' };
-    // $DisableFlowOnNegativeTest
+
+    // $FlowExpectedError
     expect(() => print(badAST)).to.throw(
       'Invalid AST Node: { random: "Data" }.',
     );

src/language/__tests__/schema-printer-test.js

@@ -21,7 +21,8 @@ describe('Printer: SDL document', () => {
 
   it('produces helpful error messages', () => {
     const badAST = { random: 'Data' };
-    // $DisableFlowOnNegativeTest
+
+    // $FlowExpectedError
     expect(() => print(badAST)).to.throw(
       'Invalid AST Node: { random: "Data" }.',
     );

src/subscription/__tests__/subscribe-test.js

@@ -322,27 +322,27 @@ describe('Subscription Initialization Phase', () => {
     `);
 
     await expectPromiseToThrow(
-      // $DisableFlowOnNegativeTest
-      () => subscribe(null, document),
+      // $FlowExpectedError
+      () => subscribe({ schema: null, document }),
       'Expected null to be a GraphQL schema.',
     );
 
     await expectPromiseToThrow(
-      // $DisableFlowOnNegativeTest
+      // $FlowExpectedError
       () => subscribe({ document }),
       'Expected undefined to be a GraphQL schema.',
     );
   });
 
   it('throws an error if document is missing', async () => {
     await expectPromiseToThrow(
-      // $DisableFlowOnNegativeTest
-      () => subscribe(emailSchema, null),
+      // $FlowExpectedError
+      () => subscribe({ schema: emailSchema, document: null }),
       'Must provide document.',
     );
 
     await expectPromiseToThrow(
-      // $DisableFlowOnNegativeTest
+      // $FlowExpectedError
       () => subscribe({ schema: emailSchema }),
       'Must provide document.',
     );
@@ -372,7 +372,7 @@ describe('Subscription Initialization Phase', () => {
   it('should pass through unexpected errors thrown in subscribe', async () => {
     let expectedError;
     try {
-      // $DisableFlowOnNegativeTest
+      // $FlowExpectedError
       await subscribe({ schema: emailSchema, document: {} });
     } catch (error) {
       expectedError = error;