Skip to content

Commit

Permalink
Replace 'Idx' with 'Index' in variable names (#3194)
Browse files Browse the repository at this point in the history
  • Loading branch information
IvanGoncharov committed Jun 22, 2021
1 parent df1bdda commit d099942
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
6 changes: 3 additions & 3 deletions benchmark/benchmark.js
Expand Up @@ -274,9 +274,9 @@ async function runBenchmarks(benchmarks, benchmarkProjects) {
}

function getArguments(argv) {
const revsIdx = argv.indexOf('--revs');
const revisions = revsIdx === -1 ? [] : argv.slice(revsIdx + 1);
const benchmarks = revsIdx === -1 ? argv : argv.slice(0, revsIdx);
const revsIndex = argv.indexOf('--revs');
const revisions = revsIndex === -1 ? [] : argv.slice(revsIndex + 1);
const benchmarks = revsIndex === -1 ? argv : argv.slice(0, revsIndex);

switch (revisions.length) {
case 0:
Expand Down
22 changes: 11 additions & 11 deletions src/jsutils/naturalCompare.ts
Expand Up @@ -6,26 +6,26 @@
*
*/
export function naturalCompare(aStr: string, bStr: string): number {
let aIdx = 0;
let bIdx = 0;
let aIndex = 0;
let bIndex = 0;

while (aIdx < aStr.length && bIdx < bStr.length) {
let aChar = aStr.charCodeAt(aIdx);
let bChar = bStr.charCodeAt(bIdx);
while (aIndex < aStr.length && bIndex < bStr.length) {
let aChar = aStr.charCodeAt(aIndex);
let bChar = bStr.charCodeAt(bIndex);

if (isDigit(aChar) && isDigit(bChar)) {
let aNum = 0;
do {
++aIdx;
++aIndex;
aNum = aNum * 10 + aChar - DIGIT_0;
aChar = aStr.charCodeAt(aIdx);
aChar = aStr.charCodeAt(aIndex);
} while (isDigit(aChar) && aNum > 0);

let bNum = 0;
do {
++bIdx;
++bIndex;
bNum = bNum * 10 + bChar - DIGIT_0;
bChar = bStr.charCodeAt(bIdx);
bChar = bStr.charCodeAt(bIndex);
} while (isDigit(bChar) && bNum > 0);

if (aNum < bNum) {
Expand All @@ -42,8 +42,8 @@ export function naturalCompare(aStr: string, bStr: string): number {
if (aChar > bChar) {
return 1;
}
++aIdx;
++bIdx;
++aIndex;
++bIndex;
}
}

Expand Down

0 comments on commit d099942

Please sign in to comment.