SingleFieldSubscriptionsRule-test: extract test schema from harness (#…

…3166)
graphql · Jun 9, 2021 · d82c8e2 · d82c8e2
1 parent 120758a
commit d82c8e2
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 31 deletions.
diff --git a/src/validation/__tests__/SingleFieldSubscriptionsRule-test.ts b/src/validation/__tests__/SingleFieldSubscriptionsRule-test.ts
@@ -1,21 +1,48 @@
 import { describe, it } from 'mocha';
 
+import { buildSchema } from '../../utilities/buildASTSchema';
+
 import { SingleFieldSubscriptionsRule } from '../rules/SingleFieldSubscriptionsRule';
 
-import {
-  expectValidationErrors,
-  expectValidationErrorsWithSchema,
-  emptySchema,
-} from './harness';
+import { expectValidationErrorsWithSchema } from './harness';
 
 function expectErrors(queryStr: string) {
-  return expectValidationErrors(SingleFieldSubscriptionsRule, queryStr);
+  return expectValidationErrorsWithSchema(
+    schema,
+    SingleFieldSubscriptionsRule,
+    queryStr,
+  );
 }
 
 function expectValid(queryStr: string) {
   expectErrors(queryStr).to.deep.equal([]);
 }
 
+const schema = buildSchema(`
+  type Message {
+    body: String
+    sender: String
+  }
+
+  type SubscriptionRoot {
+    importantEmails: [String]
+    notImportantEmails: [String]
+    moreImportantEmails: [String]
+    spamEmails: [String]
+    deletedEmails: [String]
+    newMessage: Message
+  }
+
+  type QueryRoot {
+    dummy: String
+  }
+
+  schema {
+    query: QueryRoot
+    subscription: SubscriptionRoot
+  }
+`);
+
 describe('Validate: Subscriptions with single field', () => {
   it('valid subscription', () => {
     expectValid(`
@@ -260,6 +287,12 @@ describe('Validate: Subscriptions with single field', () => {
   });
 
   it('skips if not subscription type', () => {
+    const emptySchema = buildSchema(`
+      type Query {
+        dummy: String
+      }
+    `);
+
     expectValidationErrorsWithSchema(
       emptySchema,
       SingleFieldSubscriptionsRule,

diff --git a/src/validation/__tests__/harness.ts b/src/validation/__tests__/harness.ts
@@ -130,23 +130,8 @@ export const testSchema: GraphQLSchema = buildSchema(`
     complicatedArgs: ComplicatedArgs
   }
 
-  type Message {
-    body: String
-    sender: String
-  }
-
-  type SubscriptionRoot {
-    importantEmails: [String]
-    notImportantEmails: [String]
-    moreImportantEmails: [String]
-    spamEmails: [String]
-    deletedEmails: [String]
-    newMessage: Message
-  }
-
   schema {
     query: QueryRoot
-    subscription: SubscriptionRoot
   }
 
   directive @onQuery on QUERY
@@ -159,16 +144,6 @@ export const testSchema: GraphQLSchema = buildSchema(`
   directive @onVariableDefinition on VARIABLE_DEFINITION
 `);
 
-export const emptySchema: GraphQLSchema = buildSchema(`
-  type QueryRoot {
-    empty: Boolean
-  }
-
-  schema {
-    query: QueryRoot
-  }
-`);
-
 export function expectValidationErrorsWithSchema(
   schema: GraphQLSchema,
   rule: ValidationRule,