Skip to content

Commit

Permalink
findBreakingChanges: unify how changes are collected (#1907)
Browse files Browse the repository at this point in the history
  • Loading branch information
IvanGoncharov committed May 25, 2019
1 parent f55c2a3 commit d987492
Show file tree
Hide file tree
Showing 2 changed files with 102 additions and 109 deletions.
12 changes: 6 additions & 6 deletions src/utilities/__tests__/findBreakingChanges-test.js
Expand Up @@ -973,23 +973,23 @@ describe('findDangerousChanges', () => {

expect(findDangerousChanges(oldSchema, newSchema)).to.deep.equal([
{
type: DangerousChangeType.ARG_DEFAULT_VALUE_CHANGE,
type: DangerousChangeType.TYPE_ADDED_TO_UNION,
description:
'Type1.field1 arg argThatChangesDefaultValue has changed defaultValue.',
'TypeInUnion2 was added to union type UnionTypeThatGainsAType.',
},
{
type: DangerousChangeType.VALUE_ADDED_TO_ENUM,
description: 'VALUE2 was added to enum type EnumType1.',
},
{
type: DangerousChangeType.INTERFACE_ADDED_TO_OBJECT,
type: DangerousChangeType.ARG_DEFAULT_VALUE_CHANGE,
description:
'Interface1 added to interfaces implemented by TypeThatGainsInterface1.',
'Type1.field1 arg argThatChangesDefaultValue has changed defaultValue.',
},
{
type: DangerousChangeType.TYPE_ADDED_TO_UNION,
type: DangerousChangeType.INTERFACE_ADDED_TO_OBJECT,
description:
'TypeInUnion2 was added to union type UnionTypeThatGainsAType.',
'Interface1 added to interfaces implemented by TypeThatGainsInterface1.',
},
]);
});
Expand Down

0 comments on commit d987492

Please sign in to comment.