Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add NoDeprecatedCustomRule and deprecate findDeprecatedUsages
- Loading branch information
1 parent
d10cf6c
commit f2a9252
Showing
15 changed files
with
226 additions
and
121 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
119 changes: 119 additions & 0 deletions
119
src/validation/__tests__/NoDeprecatedCustomRule-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,119 @@ | ||
// @flow strict | ||
|
||
import { describe, it } from 'mocha'; | ||
|
||
import { buildSchema } from '../../utilities/buildASTSchema'; | ||
|
||
import { NoDeprecatedCustomRule } from '../rules/custom/NoDeprecatedCustomRule'; | ||
|
||
import { expectValidationErrorsWithSchema } from './harness'; | ||
|
||
function expectErrors(queryStr) { | ||
return expectValidationErrorsWithSchema( | ||
schema, | ||
NoDeprecatedCustomRule, | ||
queryStr, | ||
); | ||
} | ||
|
||
function expectValid(queryStr) { | ||
expectErrors(queryStr).to.deep.equal([]); | ||
} | ||
|
||
const schema = buildSchema(` | ||
enum EnumType { | ||
NORMAL_VALUE | ||
DEPRECATED_VALUE @deprecated(reason: "Some enum reason.") | ||
DEPRECATED_VALUE_WITH_NO_REASON @deprecated | ||
} | ||
type Query { | ||
normalField(enumArg: [EnumType]): String | ||
deprecatedField: String @deprecated(reason: "Some field reason.") | ||
deprecatedFieldWithNoReason: String @deprecated | ||
} | ||
`); | ||
|
||
describe('Validate: no deprecated', () => { | ||
it('ignores fields and enum values that are not deprecated', () => { | ||
expectValid(` | ||
{ | ||
normalField(enumArg: [NORMAL_VALUE]) | ||
} | ||
`); | ||
}); | ||
|
||
it('ignores unknown fields and enum values', () => { | ||
expectValid(` | ||
fragment UnknownFragment on UnknownType { | ||
unknownField(unknownArg: UNKNOWN_VALUE) | ||
} | ||
fragment QueryFragment on Query { | ||
unknownField(unknownArg: UNKNOWN_VALUE) | ||
normalField(enumArg: UNKNOWN_VALUE) | ||
} | ||
`); | ||
}); | ||
|
||
it('reports error when a deprecated field is selected', () => { | ||
expectErrors(` | ||
{ | ||
normalField | ||
deprecatedField | ||
deprecatedFieldWithNoReason | ||
} | ||
`).to.deep.equal([ | ||
{ | ||
message: | ||
'The field Query.deprecatedField is deprecated. Some field reason.', | ||
locations: [{ line: 4, column: 9 }], | ||
}, | ||
{ | ||
message: | ||
'The field Query.deprecatedFieldWithNoReason is deprecated. No longer supported', | ||
locations: [{ line: 5, column: 9 }], | ||
}, | ||
]); | ||
}); | ||
|
||
it('reports error when a deprecated enum value is used', () => { | ||
expectErrors(` | ||
{ | ||
normalField(enumArg: [NORMAL_VALUE, DEPRECATED_VALUE]) | ||
normalField(enumArg: [DEPRECATED_VALUE_WITH_NO_REASON]) | ||
} | ||
`).to.deep.equal([ | ||
{ | ||
message: | ||
'The enum value "EnumType.DEPRECATED_VALUE" is deprecated. Some enum reason.', | ||
locations: [{ line: 3, column: 45 }], | ||
}, | ||
{ | ||
message: | ||
'The enum value "EnumType.DEPRECATED_VALUE_WITH_NO_REASON" is deprecated. No longer supported', | ||
locations: [{ line: 4, column: 31 }], | ||
}, | ||
]); | ||
}); | ||
|
||
it('reports error when a deprecated field is selected or an enum value is used inside a fragment', () => { | ||
expectErrors(` | ||
fragment QueryFragment on Query { | ||
deprecatedField | ||
normalField(enumArg: [NORMAL_VALUE, DEPRECATED_VALUE]) | ||
} | ||
`).to.deep.equal([ | ||
{ | ||
message: | ||
'The field Query.deprecatedField is deprecated. Some field reason.', | ||
locations: [{ line: 3, column: 9 }], | ||
}, | ||
{ | ||
message: | ||
'The enum value "EnumType.DEPRECATED_VALUE" is deprecated. Some enum reason.', | ||
locations: [{ line: 4, column: 45 }], | ||
}, | ||
]); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import { ASTVisitor } from '../../../language/visitor'; | ||
import { ValidationContext } from '../../ValidationContext'; | ||
|
||
/** | ||
* No deprecated | ||
* | ||
* A GraphQL document is only valid if all selected fields and all used enum values have not been | ||
* deprecated. | ||
* | ||
* Note: This rule is optional and is not part of the Validation section of the GraphQL | ||
* Specification. The main purpose of this rule is detection of deprecated usages and not | ||
* necessarily to forbid their use when querying a service. | ||
*/ | ||
export function NoDeprecatedCustomRule(context: ValidationContext): ASTVisitor; |
Oops, something went wrong.