visit: simplify handling of root node (#3461)

graphql · Jan 23, 2022 · f2ecc28 · f2ecc28
1 parent a91fdc6
commit f2ecc28
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/src/language/visitor.ts b/src/language/visitor.ts
@@ -192,12 +192,11 @@ export function visit(
   let keys: any = [root];
   let index = -1;
   let edits = [];
-  let node: any = undefined;
+  let node: any = root;
   let key: any = undefined;
   let parent: any = undefined;
   const path: any = [];
   const ancestors = [];
-  let newRoot = root;
   /* eslint-enable no-undef-init */
 
   do {
@@ -237,15 +236,13 @@ export function visit(
       edits = stack.edits;
       inArray = stack.inArray;
       stack = stack.prev;
-    } else {
-      key = parent ? (inArray ? index : keys[index]) : undefined;
-      node = parent ? parent[key] : newRoot;
+    } else if (parent) {
+      key = inArray ? index : keys[index];
+      node = parent[key];
       if (node === null || node === undefined) {
         continue;
       }
-      if (parent) {
-        path.push(key);
-      }
+      path.push(key);
     }
 
     let result;
@@ -300,10 +297,11 @@ export function visit(
   } while (stack !== undefined);
 
   if (edits.length !== 0) {
-    newRoot = edits[edits.length - 1][1];
+    // New root
+    return edits[edits.length - 1][1];
   }
 
-  return newRoot;
+  return root;
 }
 
 /**