Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing __Directive.args(includeDeprecated:) #3048

Closed
leebyron opened this issue Apr 22, 2021 · 1 comment
Closed

Missing __Directive.args(includeDeprecated:) #3048

leebyron opened this issue Apr 22, 2021 · 1 comment
Assignees
@IvanGoncharov
Labels
PR: bug fix 🐞 requires increase of "patch" version number spec RFC Implementation of a proposed change to the GraphQL specification

Comments

@leebyron
Copy link
Contributor

There's a missing piece of graphql/graphql-spec#805 from the PR #1560 which landed a while back:

__Directive.args(includeDeprecated:) should exist but does not according to this test:

https://github.com/graphql/graphql-js/pull/1560/files#diff-e30b759eeb9ff1ca829b96188286e61254c19417473b25c2e4a26ee9b6a8fe91R964
@leebyron leebyron added spec RFC Implementation of a proposed change to the GraphQL specification PR: bug fix 🐞 requires increase of "patch" version number labels Apr 22, 2021
@leebyron leebyron mentioned this issue Apr 22, 2021
Merged
@davidgovea davidgovea mentioned this issue Apr 27, 2021
Closed
@timbotnik timbotnik mentioned this issue May 24, 2021
Open
@falkenhawk falkenhawk mentioned this issue Oct 1, 2021
Merged
@IvanGoncharov
Copy link
Member

Fixed in #3273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IvanGoncharov IvanGoncharov

Labels
PR: bug fix 🐞 requires increase of "patch" version number spec RFC Implementation of a proposed change to the GraphQL specification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leebyron @IvanGoncharov