New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to MJS extension #1371
Switch to MJS extension #1371
Conversation
Looks like coverage is broken 😞 |
I'm sorry, I don't understand the point of this (I am not very up to date on the latest happenings in JS). Why do we want to use leebyron/iterall#34 seemed to be to allow in-line flow definitions. But we already have that for this repo, so I'm not sure what's gained here. |
Just to clarify - I was by no means suggesting a switch to MJS. Personally I dislike it 😉 My PR was solely about replacing custom bash script with a little tool that I've made for another project.
I'm not sure if rest of JS ecosystem is really going that way, from major tools only webpack has embraced it thus far as first class citizen (as far as I know). I agree with @mjmahone that it might break a lot of other tooling and personally I would advise against it at this point in time. |
The main idea here is that node.js support it natively so you don't need to use babel anymore 🎉 So ecosystem definitely moving toward native ES modules and Moreover, after we drop support for
Since node support almost all ES6 features and But on a closer look I see a few differences between this lib and
I agree it's too early. I looked at |
Looks like |
Suggested by @Andarist in #1366
Based on: leebyron/iterall#34
@mjmahone I think it's the right moment for this change since there no active PRs from 3rd-party contributors.
Note: It doesn't break Git history since files were moved using
git mv
.