feat(scalar): add generics to scalars #1522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgfidelis
approved these changes
Sep 14, 2018
5 tasks
|
fixed this 2 issues now, we got 20 more to fix like this one: I think it does not recognize that parentType can't be null in this situation |
jgcmarins
approved these changes
Sep 17, 2018
Neitsch
reviewed
Jan 6, 2019
| @@ -458,8 +458,8 @@ export function getNullableType(type) { | |||
| * These named types do not include modifiers like List or NonNull. | |||
| */ | |||
| export type GraphQLNamedType = | |||
| | GraphQLScalarType | |||
| | GraphQLObjectType | |||
| | GraphQLScalarType<any, any> | |||
| @@ -532,21 +532,21 @@ function resolveThunk<+T>(thunk: Thunk<T>): T { | |||
| * }); | |||
| * | |||
| */ | |||
| export class GraphQLScalarType { | |||
| export class GraphQLScalarType<TInternal = any, TExternal = TInternal> { | |||
There was a problem hiding this comment.
Could you explain what the purpose of / difference between TInternal and TExternal is?
|
Fixed by #3228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on gtkatakura/fullstack-challenge@36cc105
and #1487
and #576
and #914
only 2 flow erros to fix
for the first one, we can do this
for the second one, we can add a type param to valueFromASTUntyped or try to type cast the function (not sure if this is possible)