Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all ESLint rules that conflict with Prettier #1838

Merged
merged 1 commit into from Apr 29, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
143 changes: 74 additions & 69 deletions .eslintrc.yml
Expand Up @@ -40,10 +40,7 @@ rules:

flowtype/array-style-complex-type: [error, verbose]
flowtype/array-style-simple-type: [error, verbose]
flowtype/boolean-style: off
flowtype/define-flow-type: error
flowtype/delimiter-dangle: off
flowtype/generic-spacing: off
flowtype/newline-after-flow-annotation: [error, always]
flowtype/no-dupe-keys: error
flowtype/no-existential-type: off
Expand All @@ -54,25 +51,30 @@ rules:
flowtype/no-types-missing-file-annotation: error
#flowtype/no-unused-expressions: undecided
flowtype/no-weak-types: [error, { any: false }]
flowtype/object-type-delimiter: off
#flowtype/require-compound-type-alias: undecided
flowtype/require-exact-type: off
flowtype/require-parameter-type: off
flowtype/require-return-type: off
flowtype/require-types-at-top: off
flowtype/require-valid-file-annotation: [error, always, { annotationStyle: block }]
flowtype/require-variable-type: off
flowtype/semi: off
flowtype/sort-keys: off
flowtype/space-after-type-colon: off
flowtype/space-before-generic-bracket: off
flowtype/space-before-type-colon: off
flowtype/spread-exact-type: off
flowtype/type-id-match: off
flowtype/type-import-style: [error, identifier, { ignoreTypeDefault: true }]
flowtype/union-intersection-spacing: off
flowtype/use-flow-type: error
flowtype/valid-syntax: off
# Bellow rules are disabled because coflicts with Prettier, see:
# https://github.com/prettier/eslint-config-prettier/blob/master/flowtype.js
flowtype/boolean-style: off
flowtype/delimiter-dangle: off
flowtype/generic-spacing: off
flowtype/object-type-delimiter: off
flowtype/semi: off
flowtype/space-after-type-colon: off
flowtype/space-before-generic-bracket: off
flowtype/space-before-type-colon: off
flowtype/union-intersection-spacing: off

##################################################
# ESLint builtin rules list based on `v5.16.x`
Expand All @@ -98,8 +100,6 @@ rules:
no-empty-character-class: error
no-ex-assign: error
no-extra-boolean-cast: error
no-extra-parens: off
no-extra-semi: off
no-func-assign: error
no-inner-declarations: [error, functions]
no-invalid-regexp: error
Expand All @@ -110,7 +110,6 @@ rules:
no-regex-spaces: error
no-sparse-arrays: error
no-template-curly-in-string: error
no-unexpected-multiline: off
no-unreachable: error
no-unsafe-finally: error
no-unsafe-negation: error
Expand All @@ -129,7 +128,6 @@ rules:
consistent-return: off
curly: [error, all]
default-case: off
dot-location: off
dot-notation: off
eqeqeq: [error, smart]
guard-for-in: error
Expand All @@ -148,7 +146,6 @@ rules:
no-extra-bind: error
no-extra-label: error
no-fallthrough: error
no-floating-decimal: off
no-global-assign: error
no-implicit-coercion: error
no-implicit-globals: off
Expand All @@ -159,7 +156,6 @@ rules:
no-lone-blocks: error
no-loop-func: off
no-magic-numbers: off
no-multi-spaces: off
no-multi-str: error
no-new: error
no-new-func: off
Expand Down Expand Up @@ -194,7 +190,6 @@ rules:
#require-await: undecided
require-unicode-regexp: off
vars-on-top: off
wrap-iife: off
yoda: [error, never, {exceptRange: true}]

# Strict Mode
Expand Down Expand Up @@ -235,109 +230,57 @@ rules:
# Stylistic Issues
# https://eslint.org/docs/rules/#stylistic-issues

array-bracket-newline: off
array-bracket-spacing: off
array-element-newline: off
block-spacing: off
brace-style: off
camelcase: [error, {properties: always}]
#capitalized-comments: undecided
comma-dangle: off
comma-spacing: off
comma-style: off
computed-property-spacing: off
consistent-this: off
eol-last: off
func-call-spacing: off
func-name-matching: off
func-names: off
func-style: off
function-paren-newline: off
id-blacklist: off
id-length: off
id-match: [error, "^(?:_?[a-zA-Z0-9]*)|[_A-Z0-9]+$"]
implicit-arrow-linebreak: off
indent: off
jsx-quotes: off
key-spacing: off
keyword-spacing: off
#line-comment-position: undecided
linebreak-style: error
lines-around-comment: off
lines-between-class-members: off
max-depth: off
max-len: off
max-lines: off
max-lines-per-function: off
max-nested-callbacks: off
max-params: off
max-statements: off
max-statements-per-line: off
#multiline-comment-style: undecided
multiline-ternary: off
new-cap: off
new-parens: off
newline-per-chained-call: off
no-array-constructor: error
no-bitwise: off
no-continue: off
no-inline-comments: off
no-lonely-if: error
no-mixed-operators: off
no-mixed-spaces-and-tabs: off
no-multi-assign: off
no-multiple-empty-lines: off
no-negated-condition: off
no-nested-ternary: off
no-new-object: error
no-plusplus: off
no-spaced-func: off
no-restricted-syntax: off
no-tabs: error
no-ternary: off
no-trailing-spaces: off
no-underscore-dangle: off
no-unneeded-ternary: error
no-whitespace-before-property: off
nonblock-statement-body-position: off
object-curly-newline: off
object-curly-spacing: off
object-property-newline: off
one-var: [error, never]
one-var-declaration-per-line: off
operator-assignment: [error, always]
operator-linebreak: off
padded-blocks: off
padding-line-between-statements: off
prefer-object-spread: error
quote-props: off
quotes: off
semi: off
semi-spacing: off
semi-style: off
sort-keys: off
sort-vars: off
space-before-blocks: off
space-before-function-paren: off
space-in-parens: off
space-infix-ops: off
space-unary-ops: off
spaced-comment: [error, always]
switch-colon-spacing: off
template-tag-spacing: off
unicode-bom: off
wrap-regex: off

# ECMAScript 6
# https://eslint.org/docs/rules/#ecmascript-6

arrow-body-style: off
arrow-parens: off
arrow-spacing: off
constructor-super: error
generator-star-spacing: off
no-class-assign: error
no-confusing-arrow: off
no-const-assign: error
no-dupe-class-members: error
no-duplicate-imports: error
Expand All @@ -357,10 +300,72 @@ rules:
prefer-spread: off
prefer-template: off
require-yield: off
rest-spread-spacing: off
#sort-imports: undecided
#symbol-description: undecided

# Bellow rules are disabled because coflicts with Prettier, see:
# https://github.com/prettier/eslint-config-prettier/blob/master/index.js
array-bracket-newline: off
array-bracket-spacing: off
array-element-newline: off
arrow-parens: off
arrow-spacing: off
block-spacing: off
brace-style: off
comma-dangle: off
comma-spacing: off
comma-style: off
computed-property-spacing: off
dot-location: off
eol-last: off
func-call-spacing: off
function-paren-newline: off
generator-star-spacing: off
implicit-arrow-linebreak: off
indent: off
jsx-quotes: off
key-spacing: off
keyword-spacing: off
linebreak-style: error
max-len: off
multiline-ternary: off
newline-per-chained-call: off
new-parens: off
no-confusing-arrow: off
no-extra-parens: off
no-extra-semi: off
no-floating-decimal: off
no-mixed-operators: off
no-mixed-spaces-and-tabs: off
no-multi-spaces: off
no-multiple-empty-lines: off
no-spaced-func: off
no-trailing-spaces: off
no-unexpected-multiline: off
no-whitespace-before-property: off
nonblock-statement-body-position: off
object-curly-newline: off
object-curly-spacing: off
object-property-newline: off
one-var-declaration-per-line: off
operator-linebreak: off
padded-blocks: off
quote-props: off
rest-spread-spacing: off
semi: off
semi-spacing: off
semi-style: off
space-before-blocks: off
space-before-function-paren: off
space-in-parens: off
space-infix-ops: off
space-unary-ops: off
switch-colon-spacing: off
template-curly-spacing: off
template-tag-spacing: off
unicode-bom: off
wrap-iife: off
wrap-regex: off
yield-star-spacing: off

overrides:
Expand Down