Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint: enable 'arrow-body-style' rule #1840

Merged
merged 1 commit into from May 1, 2019
Merged

ESLint: enable 'arrow-body-style' rule #1840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.yml
View file
Open in desktop
Expand Up @@ -278,7 +278,7 @@ rules:
# ECMAScript 6
# https://eslint.org/docs/rules/#ecmascript-6

arrow-body-style: off
arrow-body-style: error
constructor-super: error
no-class-assign: error
no-const-assign: error
Expand Down
10 changes: 4 additions & 6 deletions src/subscription/__tests__/subscribe-test.js
View file
Open in desktop
Expand Up @@ -381,9 +381,9 @@ describe('Subscription Initialization Phase', () => {

it('resolves to an error for subscription resolver errors', async () => {
// Returning an error
const subscriptionReturningErrorSchema = emailSchemaWithResolvers(() => {
return new Error('test error');
});
const subscriptionReturningErrorSchema = emailSchemaWithResolvers(
() => new Error('test error'),
);
await testReportsError(subscriptionReturningErrorSchema);

// Throwing an error
Expand All @@ -394,9 +394,7 @@ describe('Subscription Initialization Phase', () => {

// Resolving to an error
const subscriptionResolvingErrorSchema = emailSchemaWithResolvers(
async () => {
return new Error('test error');
},
async () => new Error('test error'),
);
await testReportsError(subscriptionResolvingErrorSchema);

Expand Down