Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly trap errors in shell scripts #1844

Merged
merged 1 commit into from May 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/checkgit.sh
@@ -1,5 +1,5 @@
# Exit immediately if any subcommand terminated
trap "exit 1" TERM
trap "exit 1" ERR

#
# This script determines if current git state is the up to date master. If so
Expand Down
4 changes: 2 additions & 2 deletions resources/gitpublish.sh
@@ -1,7 +1,7 @@
#!/bin/sh -e
#!/bin/sh

# Exit immediately if any subcommand terminated
trap "exit 1" TERM
trap "exit 1" ERR

# This script maintains a git branch which mirrors master but in a form that
# what will eventually be deployed to npm, allowing npm dependencies to use:
Expand Down
2 changes: 1 addition & 1 deletion resources/prepublish.sh
@@ -1,5 +1,5 @@
# Exit immediately if any subcommand terminated
trap "exit 1" TERM
trap "exit 1" ERR

# Publishing to NPM is currently supported by Travis CI, which ensures that all
# tests pass first and the deployed module contains the correct file structure.
Expand Down