Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'Object.freeze' consistently on all exported Array/Object constants #1906

Merged
merged 1 commit into from May 24, 2019
Merged

Use 'Object.freeze' consistently on all exported Array/Object constants #1906

merged 1 commit into from May 24, 2019

Commits on May 24, 2019

  1. Use 'Object.freeze' consistently on all exported Array/Object constants 

    We already using 'Object.freeze' for many constants, e.g.:
https://github.com/graphql/graphql-js/blob/8c96dc8276f2de27b8af9ffbd71a4597d483523f/src/language/directiveLocation.js#L13
https://github.com/graphql/graphql-js/blob/8c96dc8276f2de27b8af9ffbd71a4597d483523f/src/language/kinds.js#L13
https://github.com/graphql/graphql-js/blob/dec3cc5d5133118cdb19bb90a0a770c835497835/src/language/lexer.js#L102

It helps issues with Flow since without Object.freeze it assumes that constants can be mutated
    @IvanGoncharov
    IvanGoncharov committed May 24, 2019
    Copy the full SHA
    c334786 View commit details
    Browse the repository at this point in the history