Accept normal object as 'variableValues' arg of 'graphql' function #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synchronise it with same argument of 'execute' https://github.com/graphql/graphql-js/blob/master/src/execution/execute.js#L102 Plus in most cases result of `JSON.parse` is passed, which is normal object.
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Jun 1, 2019
Duplicate graphql#1937 but for 'subscribe' and 'createSourceEventStream' functions
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Jun 1, 2019
Duplicate graphql#1937 but for 'subscribe' and 'createSourceEventStream' functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronise it with same argument of 'execute'
https://github.com/graphql/graphql-js/blob/master/src/execution/execute.js#L102
Plus in most cases result of
JSON.parseis passed, which is normalobject.