Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[printError] Make location formatting IDE friendly #1949

Merged

Conversation

alloy
Copy link
Contributor

@alloy alloy commented Jun 4, 2019

This is the format used by jest, flow, typescript, and many others.

As an example, this change when used in relay changes the experience like so:

Before

relay-ide-friendly-errors-before

After

relay-ide-friendly-errors-after

This is the format used by jest, flow,
typescript, and many others.
@IvanGoncharov IvanGoncharov added the PR: feature 🚀 requires increase of "minor" version number label Jun 4, 2019
@IvanGoncharov IvanGoncharov merged commit b42f8c8 into graphql:master Jun 4, 2019
@IvanGoncharov
Copy link
Member

@alloy Merged 🎉 Thanks 👍

@alloy alloy deleted the ide-friendly-error-source-location branch June 4, 2019 15:56
@jbaxleyiii
Copy link

@alloy this is so wonderful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature 🚀 requires increase of "minor" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants