Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gen-changelog: remove hardcoded GitHub org and repo #2035

Merged
merged 1 commit into from Jul 15, 2019
Merged

gen-changelog: remove hardcoded GitHub org and repo #2035

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 17 additions & 3 deletions resources/gen-changelog.js
View file
Open in desktop
Expand Up @@ -42,6 +42,20 @@ if (!GH_TOKEN) {
process.exit(1);
}

if (!packageJSON.repository || typeof packageJSON.repository.url !== 'string') {
console.error('package.json is missing repository.url string!');
process.exit(1);
}

const match = /https:\/\/github.com\/([^/]+)\/([^/]+).git/.exec(
packageJSON.repository.url,
);
if (match == null) {
console.error('Can not extract organisation and repo name from repo URL!');
process.exit(1);
}
const [, githubOrg, githubRepo] = match;

getChangeLog()
.then(changelog => process.stdout.write(changelog))
.catch(error => console.error(error));
Expand Down Expand Up @@ -120,7 +134,7 @@ function graphqlRequestImpl(query, variables, cb) {
headers: {
Authorization: 'bearer ' + GH_TOKEN,
'Content-Type': 'application/json',
'User-Agent': 'graphql-js-changelog',
'User-Agent': 'gen-changelog',
},
});

Expand Down Expand Up @@ -200,7 +214,7 @@ async function batchCommitInfo(commits) {

const response = await graphqlRequest(`
{
repository(owner: "graphql", name: "graphql-js") {
repository(owner: "${githubOrg}", name: "${githubRepo}") {
${commitsSubQuery}
}
}
Expand All @@ -217,7 +231,7 @@ function commitsInfoToPRs(commits) {
const prs = {};
for (const commit of commits) {
const associatedPRs = commit.associatedPullRequests.nodes.filter(
pr => pr.repository.nameWithOwner === 'graphql/graphql-js',
pr => pr.repository.nameWithOwner === `${githubOrg}/${githubRepo}`,
);
if (associatedPRs.length === 0) {
throw new Error(
Expand Down