RFC: Lexing is Greedy #2163
Merged
RFC: Lexing is Greedy #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the test cases described in graphql/graphql-spec#599 Makes the lookahead restriction change necessary for the new tests to pass for numbers, all other tests are already passing.
leebyron
added
the
spec RFC
IvanGoncharov
approved these changes
Sep 12, 2019
IvanGoncharov
added
the
PR: bug fix 🐞
This was referenced Oct 26, 2019
This was referenced Feb 12, 2020
This was referenced Feb 23, 2020
This was referenced Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the test cases described in graphql/graphql-spec#599
Makes the lookahead restriction change necessary for the new tests to pass for numbers, all other tests are already passing.