Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tstypes: fix typings for 'isSpecifiedDirective'/'isSpecifiedScalarType' #2195

Merged
merged 1 commit into from Sep 25, 2019

Conversation

IvanGoncharov
Copy link
Member

Fixes #2153

@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Sep 25, 2019
@IvanGoncharov
Copy link
Member Author

Since we still discussing a long-term solution in #2194 vs #2196 for 14.x.x branch it would be best to just revert to boolean since it was what we had in DefinetlyTyped anyway:

export function isSpecifiedScalarType(type: GraphQLScalarType): boolean;

@IvanGoncharov IvanGoncharov merged commit 1a0e918 into graphql:14.x.x Sep 25, 2019
@IvanGoncharov IvanGoncharov deleted the 14.x.x branch September 25, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant