separateOperations: stop unused fragments from being included #2853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
separateOperations
method sometimes include unused fragments if you name an operation the same thing as a fragment:When running
separateOperations
on the above, and then looking at.Ones
of the result, we get:This happens because in the dependency graph, there's nothing differentiating an operation from a fragment. They are just added by name. So in the scenario above the fragment
One
will add the queryOne
as a dependecy ofOnes
, and then the queryOne
has the fragmentTwo
as a dependency, so that will be added too.I fixed this by adding a prefix to the names in the dependecy graph, so operations can't be added a dependencies anymore, only fragments.