Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Assert subscription field is not introspection. #2861

Merged
merged 15 commits into from Jun 3, 2021
Merged

RFC: Assert subscription field is not introspection. #2861

merged 15 commits into from Jun 3, 2021

Commits on May 27, 2021

  1. Assert subscription field is not introspection.

    @benjie
    benjie committed May 27, 2021
    Copy the full SHA
    947f88d View commit details
    Browse the repository at this point in the history

  2. Walk selection set fully

    @benjie
    benjie committed May 27, 2021
    Copy the full SHA
    fe4e704 View commit details
    Browse the repository at this point in the history

  3. More tests

    @benjie
    benjie committed May 27, 2021
    Copy the full SHA
    14e1450 View commit details
    Browse the repository at this point in the history

  4. Remove responseKeys.size > 0 assertion to appease code coverage

    @benjie
    benjie committed May 27, 2021
    Copy the full SHA
    4117885 View commit details
    Browse the repository at this point in the history

  5. Spam more tests to attempt to appease code coverage

    @benjie
    benjie committed May 27, 2021
    Copy the full SHA
    7263b83 View commit details
    Browse the repository at this point in the history

  6. Finally appease codecov

    @benjie
    benjie committed May 27, 2021
    Copy the full SHA
    7ca9805 View commit details
    Browse the repository at this point in the history

  7. Typo

    @benjie
    benjie committed May 27, 2021
    Copy the full SHA
    a846b2b View commit details
    Browse the repository at this point in the history

  8. Add test to demonstrate that recursive fragments don't cause infinite… 

    … loop
    @benjie
    benjie committed May 27, 2021
    Copy the full SHA
    2e8c635 View commit details
    Browse the repository at this point in the history

  9. Reflect @leebyron's PR feedback

    @benjie
    benjie committed May 27, 2021
    Copy the full SHA
    9a69bb1 View commit details
    Browse the repository at this point in the history

  10. Appease codecoverage

    @benjie
    benjie committed May 27, 2021
    Copy the full SHA
    9f718b8 View commit details
    Browse the repository at this point in the history

  11. Apply changes Ivan requested

    @benjie
    benjie committed May 27, 2021
    Copy the full SHA
    ad2f93f View commit details
    Browse the repository at this point in the history

  12. It's TypeScript now

    @benjie
    benjie committed May 27, 2021
    Copy the full SHA
    ce36b47 View commit details
    Browse the repository at this point in the history

  13. collectFields returns a Map now

    @benjie
    benjie committed May 27, 2021
    Copy the full SHA
    8d9822d View commit details
    Browse the repository at this point in the history

  14. Slightly more efficient code

    @benjie
    benjie committed May 27, 2021
    Copy the full SHA
    06b7587 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. Apply suggestions from code review

    @IvanGoncharov
    IvanGoncharov committed Jun 3, 2021
    Copy the full SHA
    5ba89bb View commit details
    Browse the repository at this point in the history