Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert GraphQLList and GraphQLNonNull into proper classes #2906

Merged
merged 1 commit into from Feb 2, 2021

Conversation

IvanGoncharov
Copy link
Member

No description provided.

@IvanGoncharov IvanGoncharov added the PR: breaking change 💥 implementation requires increase of "major" version number label Feb 1, 2021
@IvanGoncharov IvanGoncharov merged commit ddb7264 into graphql:main Feb 2, 2021
@IvanGoncharov IvanGoncharov deleted the pr_branch branch February 2, 2021 16:56
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this pull request Feb 20, 2021
martijnwalraven added a commit to apollographql/federation that referenced this pull request Mar 25, 2021
This was always the recommended style, but now that `GraphQLNonNull` and `GraphQLList` have been converted to proper classes in graphql/graphql-js#2906, calling them as functions no longer works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: breaking change 💥 implementation requires increase of "major" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant