Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use regexp-exec #2928

Merged
merged 1 commit into from Feb 19, 2021
Merged

refactor: use regexp-exec #2928

merged 1 commit into from Feb 19, 2021

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Feb 18, 2021

This typescript eslint ruleprefer-regexp-exec is enabled so we should use exec over match. Cherry-picked from #2828

@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Feb 19, 2021
@IvanGoncharov IvanGoncharov merged commit 0a10230 into graphql:main Feb 19, 2021
IvanGoncharov pushed a commit to IvanGoncharov/graphql-js that referenced this pull request Feb 20, 2021
@saihaj @IvanGoncharov
refactor: use regexp-exec (graphql#2928)
12b1c61 
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/prefer-regexp-exec.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saihaj @IvanGoncharov