Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove override of node/global-require rule for resources dir #2970

Merged
merged 1 commit into from Mar 13, 2021
Merged

Remove override of node/global-require rule for resources dir #2970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintrc.yml
View file
Open in desktop
Expand Up @@ -688,7 +688,6 @@ overrides:
rules:
node/no-unpublished-require: off
node/no-sync: off
node/global-require: off
import/no-extraneous-dependencies: [error, { devDependencies: true }]
import/no-nodejs-modules: off
import/no-commonjs: off
Expand Down
5 changes: 4 additions & 1 deletion resources/build-npm.js
View file
Open in desktop
Expand Up @@ -55,7 +55,10 @@ function babelBuild(srcPath, options) {
}

function buildPackageJSON() {
const packageJSON = require('../package.json');
const packageJSON = JSON.parse(
fs.readFileSync(require.resolve('../package.json'), 'utf-8'),
);

delete packageJSON.private;
delete packageJSON.scripts;
delete packageJSON.devDependencies;
Expand Down
4 changes: 3 additions & 1 deletion resources/eslint-internal-rules/index.js
View file
Open in desktop
@@ -1,7 +1,9 @@
'use strict';

const noDirImport = require('./no-dir-import');

module.exports = {
rules: {
'no-dir-import': require('./no-dir-import'),
'no-dir-import': noDirImport,
},
};