Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(language/ast.d.ts): use Kind enum type #2984

Merged
merged 4 commits into from Oct 13, 2021
Merged

refactor(language/ast.d.ts): use Kind enum type #2984

merged 4 commits into from Oct 13, 2021

Conversation

jjangga0214
Copy link
Contributor

This is a simple refactoring, thus I don't think I should explain.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 24, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

saihaj
saihaj approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏼

@jjangga0214
Copy link
Contributor Author

Hi, it has been a long time..

Should I resolve the conflict?
Or somebody would do that?

Anyway, is this eventually to be reviewed and merged someday?

@saihaj
Copy link
Member

saihaj commented Jun 29, 2021 •
edited

Hey @jjangga0214 please resolve conflicts and we will get this in. We were waiting on TypeScript migration to complete and now it is done so we should be good to merge this in.

@jjangga0214 jjangga0214 force-pushed the refactor/use-kind-enum-in-ast-0 branch from 10a8570 to 796211c Compare June 30, 2021 22:51
@jjangga0214
Copy link
Contributor Author

jjangga0214 commented Jun 30, 2021 •
edited

We were waiting on TypeScript migration to complete

Aha, I see :)

please resolve conflicts

It's now rebased.

@jjangga0214
Copy link
Contributor Author

jjangga0214 commented Jul 1, 2021 •
edited

Fixed mistakenly placed types while resolving conflict.

I think it's now really ready to be merged.

Thanks!

saihaj
saihaj reviewed Jul 1, 2021
View reviewed changes
src/language/kinds.ts Outdated Show resolved Hide resolved
@IvanGoncharov
Copy link
Member

@jjangga0214 Thanks for updating PR 👍
I will review it on Monday.

@yaacovCR
Copy link
Contributor

This can probably be merged now.....right?

@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Oct 13, 2021
@IvanGoncharov IvanGoncharov merged commit d48d502 into graphql:main Oct 13, 2021
@jjangga0214 jjangga0214 deleted the refactor/use-kind-enum-in-ast-0 branch January 28, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saihaj saihaj saihaj approved these changes

@IvanGoncharov IvanGoncharov Awaiting requested review from IvanGoncharov

Assignees
No one assigned
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jjangga0214 @saihaj @IvanGoncharov @yaacovCR