refactor(language/ast.d.ts): use Kind enum type #2984
Merged
+44
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi, it has been a long time.. Should I resolve the conflict? Anyway, is this eventually to be reviewed and merged someday? |
|
Hey @jjangga0214 please resolve conflicts and we will get this in. We were waiting on TypeScript migration to complete and now it is done so we should be good to merge this in. |
jjangga0214
force-pushed
the
refactor/use-kind-enum-in-ast-0
branch
from
10a8570 to
796211c
Compare
Aha, I see :)
It's now rebased. |
|
Fixed mistakenly placed types while resolving conflict. I think it's now really ready to be merged. Thanks! |
saihaj
reviewed
Jul 1, 2021
|
@jjangga0214 Thanks for updating PR 👍 |
|
This can probably be merged now.....right? |
IvanGoncharov
added
the
PR: polish 💅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple refactoring, thus I don't think I should explain.