Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow: Improve typings for exported definitions #2992

Merged
merged 1 commit into from Mar 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/validation/__tests__/harness.js
Expand Up @@ -9,7 +9,7 @@ import { buildSchema } from '../../utilities/buildASTSchema';
import { validate, validateSDL } from '../validate';
import type { ValidationRule, SDLValidationRule } from '../ValidationContext';

export const testSchema = buildSchema(`
export const testSchema: GraphQLSchema = buildSchema(`
interface Being {
name(surname: Boolean): String
}
Expand Down
38 changes: 21 additions & 17 deletions src/validation/specifiedRules.js
@@ -1,3 +1,5 @@
import type { ValidationRule, SDLValidationRule } from './ValidationContext';

// Spec Section: "Executable Definitions"
import { ExecutableDefinitionsRule } from './rules/ExecutableDefinitionsRule';

Expand Down Expand Up @@ -97,7 +99,7 @@ import { PossibleTypeExtensionsRule } from './rules/PossibleTypeExtensionsRule';
* The order of the rules in this list has been adjusted to lead to the
* most clear output when encountering multiple validation errors.
*/
export const specifiedRules = Object.freeze([
export const specifiedRules: $ReadOnlyArray<ValidationRule> = Object.freeze([
ExecutableDefinitionsRule,
UniqueOperationNamesRule,
LoneAnonymousOperationRule,
Expand Down Expand Up @@ -129,19 +131,21 @@ export const specifiedRules = Object.freeze([
/**
* @internal
*/
export const specifiedSDLRules = Object.freeze([
LoneSchemaDefinitionRule,
UniqueOperationTypesRule,
UniqueTypeNamesRule,
UniqueEnumValueNamesRule,
UniqueFieldDefinitionNamesRule,
UniqueDirectiveNamesRule,
KnownTypeNamesRule,
KnownDirectivesRule,
UniqueDirectivesPerLocationRule,
PossibleTypeExtensionsRule,
KnownArgumentNamesOnDirectivesRule,
UniqueArgumentNamesRule,
UniqueInputFieldNamesRule,
ProvidedRequiredArgumentsOnDirectivesRule,
]);
export const specifiedSDLRules: $ReadOnlyArray<SDLValidationRule> = Object.freeze(
[
LoneSchemaDefinitionRule,
UniqueOperationTypesRule,
UniqueTypeNamesRule,
UniqueEnumValueNamesRule,
UniqueFieldDefinitionNamesRule,
UniqueDirectiveNamesRule,
KnownTypeNamesRule,
KnownDirectivesRule,
UniqueDirectivesPerLocationRule,
PossibleTypeExtensionsRule,
KnownArgumentNamesOnDirectivesRule,
UniqueArgumentNamesRule,
UniqueInputFieldNamesRule,
ProvidedRequiredArgumentsOnDirectivesRule,
],
);