Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: discrepancies between Flow and TS types #3001

Merged
merged 8 commits into from Mar 30, 2021
Merged

fix: discrepancies between Flow and TS types #3001

merged 8 commits into from Mar 30, 2021

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Mar 29, 2021

Split PR #2985

  • feat: remove unexported type
  • feat: exported type should be readonly
  • feat: add get Symbol.toStringTag
  • feat: add internal annotations
  • fix: match type as per flow def
  • feat: add type for [Symbol.toStringTag] getter
  • fix: match input type with flow
  • fix: match return return type with flow

@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Mar 30, 2021
@IvanGoncharov IvanGoncharov changed the title fix: d.ts types fix: discrepancies between Flow and TS types Mar 30, 2021
@IvanGoncharov IvanGoncharov merged commit 58b9cd5 into graphql:main Mar 30, 2021
@saihaj saihaj deleted the split-pr branch March 30, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanGoncharov IvanGoncharov Awaiting requested review from IvanGoncharov

Assignees
No one assigned
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saihaj @IvanGoncharov