Skip to content

fix: discrepancies between Flow and TS types #3001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 30, 2021
Merged

fix: discrepancies between Flow and TS types #3001

merged 8 commits into from
Mar 30, 2021
+25 −16

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Mar 29, 2021

Split PR #2985

  • feat: remove unexported type
  • feat: exported type should be readonly
  • feat: add get Symbol.toStringTag
  • feat: add internal annotations
  • fix: match type as per flow def
  • feat: add type for [Symbol.toStringTag] getter
  • fix: match input type with flow
  • fix: match return return type with flow

saihaj added 8 commits March 29, 2021 14:05
@saihaj
feat: remove unexported type

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c7deab1 
this is not exported from `lexer.js`
@saihaj
feat: exported type should be readonly

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b569969 
Object is freezed to makes sense to provide readonly types
@saihaj
feat: add get Symbol.toStringTag

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a634276
@saihaj
feat: add internal annotations
f95f829 
in sync with flow exported types
@saihaj
fix: match type as per flow def
ea4867c
@saihaj
feat: add type for [Symbol.toStringTag] getter
f81ef71
@saihaj
fix: match input type with flow
e0b31d5
@saihaj
fix: match return return type with flow
a8c35dd
@saihaj saihaj requested a review from IvanGoncharov March 29, 2021 19:12
@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Mar 30, 2021
@IvanGoncharov IvanGoncharov changed the title fix: d.ts types fix: discrepancies between Flow and TS types Mar 30, 2021
@IvanGoncharov IvanGoncharov merged commit 58b9cd5 into graphql:main Mar 30, 2021
@saihaj saihaj deleted the split-pr branch March 30, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanGoncharov IvanGoncharov

Assignees
No one assigned
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saihaj @IvanGoncharov