New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema Coordinates #3044
base: main
Are you sure you want to change the base?
Schema Coordinates #3044
Conversation
c7b87e2
to
0a5630a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
This is way beyond what I was hacking with. Hadn't even considered reusing the existing parser. (I was fiddling around with regexes...)
Thanks for putting this together - this makes a lot of sense.
src/language/printer.js
Outdated
isDirective && '@', | ||
name, | ||
wrap('.', fieldName), | ||
wrap('(', argumentName, ':)'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
a4a8920
to
42f9072
Compare
Great feedback - I think I've resolved both:
|
42f9072
to
1399f7c
Compare
3451e3e
to
2f893d6
Compare
1399f7c
to
3cec8c2
Compare
3cec8c2
to
e688f88
Compare
e688f88
to
c68ca9b
Compare
c68ca9b
to
8fa8a4c
Compare
Implements graphql/graphql-spec#794 Adds: * DOT punctuator in lexer * Improvements to lexer errors around misuse of `.` * Minor improvement to parser core which simplified this addition * `SchemaCoordinate` node and `isSchemaCoodinate()` predicate * Support in `print()` and `visit()` * Added function `parseSchemaCoordinate()` since it is a parser entry point. * Added function `resolveSchemaCoordinate()` and `resolveASTSchemaCoordinate()` which implement the semantics (name mirrored from `buildASTSchema`) as well as the return type `ResolvedSchemaElement`
8fa8a4c
to
98e7541
Compare
Depends on #3115
Implements graphql/graphql-spec#794
Adds:
.
SchemaCoordinate
node andisSchemaCoodinate()
predicateprint()
andvisit()
parseSchemaCoordinate()
since it is a parser entry point.resolveSchemaCoordinate()
andresolveASTSchemeCoordinate()
which implement the semantics (name mirrored frombuildASTSchema
) as well as the return typeGraphQLSchemaElement