Fix #2895 inputValueDeprecation: true getIntrospectionQuery error
#3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgovea
force-pushed
the
2895-deprecated-fields
branch
from
2dedea9
to
a69c849
Compare
davidgovea
changed the title
inputValueDeprecation: true getIntrospectionQuery errorinputValueDeprecation: true getIntrospectionQuery error
|
Could this be considered by maintainers? We're waiting for this fix at Open Collective. Happy to help in any way! |
|
@IvanGoncharov no hurry but could you have a look and tell us what to expect about this PR? |
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Sep 24, 2021
|
@davidgovea Thanks for PR and sorry for the late review :( |
|
Thanks @IvanGoncharov! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2895
includeDeprecatedfrom directive is the right approach, but tests are passing