Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine parse and AST to represent ConstValue #3059

Merged
merged 1 commit into from May 8, 2021
Merged

Conversation

leebyron
Copy link
Contributor

@leebyron leebyron commented May 5, 2021

This adds:

  • ConstValueNode - A subtype of ValueNode which recursively excludes Variables
  • Improved syntax error when encountering variable in a const value
  • parseConstValue(): ConstValueNode
  • isConstValue(): ConstValueNode
  • Various refinements to AST types to use ConstValueNode (or a type which includes it) to better align to the spec.

@leebyron leebyron force-pushed the const-value-ast branch 2 times, most recently from a7be8ab to 0e53b31 Compare May 6, 2021 03:58
src/language/ast.js Outdated Show resolved Hide resolved
This adds:

* ConstValueNode - A subtype of ValueNode which recursively excludes Variables
* Improved syntax error when encountering variable in a const value
* parseConstValue(): ConstValueNode
* isConstValue(): ConstValueNode
* Various refinements to AST types to use ConstValueNode (or a type which includes it) to better align to the spec.
@IvanGoncharov IvanGoncharov merged commit 513eacc into main May 8, 2021
@IvanGoncharov IvanGoncharov deleted the const-value-ast branch May 8, 2021 06:22
@IvanGoncharov IvanGoncharov added the PR: feature 🚀 requires increase of "minor" version number label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature 🚀 requires increase of "minor" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants