Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscription-test: use separate dummy query type #3069

Merged
merged 1 commit into from May 10, 2021
Merged

subscription-test: use separate dummy query type #3069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 20 additions & 13 deletions src/subscription/__tests__/subscribe-test.js
View file
Open in desktop
Expand Up @@ -143,11 +143,18 @@ async function expectPromise(promise: Promise<mixed>) {
};
}

const DummyQueryType = new GraphQLObjectType({
name: 'Query',
fields: {
dummy: { type: GraphQLString },
},
});

// Check all error cases when initializing the subscription.
describe('Subscription Initialization Phase', () => {
it('accepts multiple subscription fields defined in schema', async () => {
const schema = new GraphQLSchema({
query: QueryType,
query: DummyQueryType,
subscription: new GraphQLObjectType({
name: 'Subscription',
fields: {
Expand Down Expand Up @@ -183,7 +190,7 @@ describe('Subscription Initialization Phase', () => {
}

const schema = new GraphQLSchema({
query: QueryType,
query: DummyQueryType,
subscription: new GraphQLObjectType({
name: 'Subscription',
fields: {
Expand Down Expand Up @@ -216,7 +223,7 @@ describe('Subscription Initialization Phase', () => {
}

const schema = new GraphQLSchema({
query: QueryType,
query: DummyQueryType,
subscription: new GraphQLObjectType({
name: 'Subscription',
fields: {
Expand Down Expand Up @@ -255,7 +262,7 @@ describe('Subscription Initialization Phase', () => {
let didResolveBar = false;

const schema = new GraphQLSchema({
query: QueryType,
query: DummyQueryType,
subscription: new GraphQLObjectType({
name: 'Subscription',
fields: {
Expand All @@ -267,7 +274,7 @@ describe('Subscription Initialization Phase', () => {
},
},
bar: {
type: EmailEventType,
type: GraphQLString,
// istanbul ignore next (Shouldn't be called)
subscribe() {
didResolveBar = true;
Expand Down Expand Up @@ -295,7 +302,7 @@ describe('Subscription Initialization Phase', () => {
it('throws an error if some of required arguments are missing', async () => {
const document = parse('subscription { foo }');
const schema = new GraphQLSchema({
query: QueryType,
query: DummyQueryType,
subscription: new GraphQLObjectType({
name: 'Subscription',
fields: {
Expand Down Expand Up @@ -327,7 +334,7 @@ describe('Subscription Initialization Phase', () => {

it('resolves to an error for unknown subscription field', async () => {
const schema = new GraphQLSchema({
query: QueryType,
query: DummyQueryType,
subscription: new GraphQLObjectType({
name: 'Subscription',
fields: {
Expand All @@ -350,7 +357,7 @@ describe('Subscription Initialization Phase', () => {

it('should pass through unexpected errors thrown in subscribe', async () => {
const schema = new GraphQLSchema({
query: QueryType,
query: DummyQueryType,
subscription: new GraphQLObjectType({
name: 'Subscription',
fields: {
Expand All @@ -365,7 +372,7 @@ describe('Subscription Initialization Phase', () => {

it('throws an error if subscribe does not return an iterator', async () => {
const schema = new GraphQLSchema({
query: QueryType,
query: DummyQueryType,
subscription: new GraphQLObjectType({
name: 'Subscription',
fields: {
Expand All @@ -387,7 +394,7 @@ describe('Subscription Initialization Phase', () => {
it('resolves to an error for subscription resolver errors', async () => {
async function subscribeWithFn(subscribeFn: () => mixed) {
const schema = new GraphQLSchema({
query: QueryType,
query: DummyQueryType,
subscription: new GraphQLObjectType({
name: 'Subscription',
fields: {
Expand Down Expand Up @@ -439,7 +446,7 @@ describe('Subscription Initialization Phase', () => {

it('resolves to an error if variables were wrong type', async () => {
const schema = new GraphQLSchema({
query: QueryType,
query: DummyQueryType,
subscription: new GraphQLObjectType({
name: 'Subscription',
fields: {
Expand Down Expand Up @@ -853,7 +860,7 @@ describe('Subscription Publish Phase', () => {
}

const schema = new GraphQLSchema({
query: QueryType,
query: DummyQueryType,
subscription: new GraphQLObjectType({
name: 'Subscription',
fields: {
Expand Down Expand Up @@ -914,7 +921,7 @@ describe('Subscription Publish Phase', () => {
}

const schema = new GraphQLSchema({
query: QueryType,
query: DummyQueryType,
subscription: new GraphQLObjectType({
name: 'Subscription',
fields: {
Expand Down