Export TypeKind as value #3178
Merged
Export TypeKind as value #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@janicduplessis Thanks for reporting 👍 |
IvanGoncharov
added
the
PR: bug fix 🐞
|
@janicduplessis Thanks a lot for a fix! |
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Jun 18, 2021
Motivated by graphql#3178
Drama123543
added a commit
to view-code/graphql-js
that referenced
this pull request
Jul 2, 2021
This reverts commit 40db639.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeKindis currently exported as a type intype/index.tsbut then re-exported as a value inindex.ts. This causes the following error in webpack since type export are removed.TypeKindseems to be a value so I changed it to be exported as a value intype/index.ts.Tested that this fixes the issue in an app.