Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: execution methods into Executor class #3185

Merged
merged 20 commits into from Jun 21, 2021
Merged

refactor: execution methods into Executor class #3185

merged 20 commits into from Jun 21, 2021

Commits on Jun 21, 2021

  1. refactor: execution methods into Executor class 

    see: graphql#3163 (comment)

depends on graphql#3184
    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    4f64c04 View commit details
    Browse the repository at this point in the history

  2. don't make things protected unnecessarily

    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    11e9aa9 View commit details
    Browse the repository at this point in the history

  3. spread exeContext properties into the class

    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    25f3441 View commit details
    Browse the repository at this point in the history

  4. split Executor class into separate file 

    note that the Parser class is contained in lowercase parser.ts
    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    0988929 View commit details
    Browse the repository at this point in the history

  5. fold argument checking inside buildExecutionContext

    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    215cd04 View commit details
    Browse the repository at this point in the history

  6. consolidate more into the Executor

    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    40a64c2 View commit details
    Browse the repository at this point in the history

  7. put a little more in the SubscriptionExecutor

    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    8f8825a View commit details
    Browse the repository at this point in the history

  8. fold createSourceEventStream into the SubscriptionExecutor

    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    b4ad7b8 View commit details
    Browse the repository at this point in the history

  9. move even more into the SubscriptionExecutor

    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    4aacaae View commit details
    Browse the repository at this point in the history

  10. Extract SubscriptionExecutor into its own file 

    in preparation for merging with Executor
    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    c99d23a View commit details
    Browse the repository at this point in the history

  11. consolidate SubscriptionExecutor into Executor

    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    774f2b2 View commit details
    Browse the repository at this point in the history

  12. make buildExecutionContext a static method on Executor 

    makes execute file even thinner
    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    f8213a2 View commit details
    Browse the repository at this point in the history

  13. streamline even further

    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    2f8cf87 View commit details
    Browse the repository at this point in the history

  14. fix

    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    d3f99c6 View commit details
    Browse the repository at this point in the history

  15. add test for code coverage

    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    944f01f View commit details
    Browse the repository at this point in the history

  16. lint

    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    935a2df View commit details
    Browse the repository at this point in the history

  17. move all subscription files into execution

    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    8e8b85e View commit details
    Browse the repository at this point in the history

  18. organize imports

    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    cffc71e View commit details
    Browse the repository at this point in the history

  19. retire BuildExecutionContextArgs 

    in favor of union of ExecutionArgs & SubscriptionArgs
    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    bcf5a72 View commit details
    Browse the repository at this point in the history

  20. add comment for subscriptions

    @yaacovCR
    yaacovCR committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    372d0eb View commit details
    Browse the repository at this point in the history