refactor: introduce MaybePromise thenable #3205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacovCR
force-pushed
the
maybe-promise
branch
4 times, most recently
from
6ef9c77
to
d817623
Compare
|
This change eliminates code duplication between the promise and non-promise pathways, reducing the size of the |
|
@IvanGoncharov, ready for review. |
yaacovCR
force-pushed
the
refactor-execution
branch
from
176ea26
to
c124435
Compare
and verbose comment (to be deduplicated later)
yaacovCR
force-pushed
the
maybe-promise
branch
from
d817623
to
d0a3653
Compare
|
Closing for now, possibly to revisit if @IvanGoncharov has more interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
https://github.com/yaacovCR/value-or-promise/#inspiration
https://github.com/yaacovCR/value-or-promise/
depends on #3193