Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TResult to GraphQLFieldResolver signature #3255

Merged

Conversation

tgriesser
Copy link
Contributor

Tried out the 16.0.0-rc and noticed the change from return type of GraphQLFieldResolver from any in 15.x to unknown. While this type change is correct, it'd be better if the generic could be specified by a consumer library, for instance if maintaining the previous behavior of any is desired in a library usage.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 2, 2021

CLA Signed

The committers are authorized under a signed CLA.

@IvanGoncharov IvanGoncharov added the PR: feature 🚀 requires increase of "minor" version number label Sep 15, 2021
@IvanGoncharov IvanGoncharov merged commit e88c58e into graphql:main Sep 15, 2021
@IvanGoncharov
Copy link
Member

@tgriesser Thanks a lot.

While this type change is correct, it'd be better if the generic could be specified by a consumer library, for instance if maintaining the previous behavior of any is desired in a library usage.

Totally agree 👍
Also, it should help server-side codegen.

I will release it in the next RC.
I also can add this argument to 15.x.x line, if you need to support both versions in your lib, just create PR against the 15.x.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature 🚀 requires increase of "minor" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants