Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lexer: Remove superfluous statement in readDigits #3264

Merged
merged 2 commits into from Sep 20, 2021
Merged

lexer: Remove superfluous statement in readDigits #3264

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f03a25
lexer: Remove superfluous statement in `readDigits`
Cito Sep 18, 2021
a4f5be9
review changes
IvanGoncharov Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/language/lexer.ts
View file
Open in desktop
Expand Up @@ -490,11 +490,10 @@ function readDigits(lexer: Lexer, start: number, firstCode: number): number {

const body = lexer.source.body;
let position = start;
let code = firstCode;

do {
code = body.charCodeAt(++position);
} while (isDigit(code));
// empty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty loops can look suspicious in code.
I moved increate to be the loop body since it's the purpose of this code to calculate position.

} while (isDigit(body.charCodeAt(++position)));

return position;
}
Expand Down