Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 'graphql/subscriptions' and move code to 'execution' #3292

Merged
merged 1 commit into from Oct 7, 2021

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Oct 7, 2021

move the files from the subscription module into execution, in preparation for code integration

see:
#3195 (review)
#3195 (comment)

move the files from the subscription module into execution, in preparation for code integration
@IvanGoncharov IvanGoncharov changed the title refactor: move graphql-subscription Deprecate 'graphql/subscriptions' and move code to 'graphql/execution' Oct 7, 2021
@IvanGoncharov IvanGoncharov changed the title Deprecate 'graphql/subscriptions' and move code to 'graphql/execution' Deprecate 'graphql/subscriptions' and move code to 'execution' Oct 7, 2021
@IvanGoncharov IvanGoncharov merged commit 588d096 into main Oct 7, 2021
@IvanGoncharov IvanGoncharov deleted the move-subscription-files branch October 7, 2021 13:56
@IvanGoncharov
Copy link
Member

@yaacovCR Thanks a lot, was a pleasure to review 👍
One thing, we use PR title in changelog so it should explain the effect of changes and not the intention of changes.
Even if in the future we will use another mechanism for maintaining changelog, I still think it will benefit users to have commit messages in that style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants