Align calls of buildExecutionContext #3293
Merged
+16
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`buildExecutionContext` used to throw an error on failure, but was changed to return an array of errors (enabling the function to return multiple errors encountered during variable coercion). As the function is no longer designed to throw, it no longer needs to be wrapped in a try block when used within the `subscribe` function. This change aligns the use of `buildExecutionContext between the `subscribe` and `execute` functions.
|
@IvanGoncharov , the integration check failure seems spurious, i think this is ready for review |
|
@yaacovCR it is failing because of npm outage https://status.npmjs.org/ |
ah. passing now. |
IvanGoncharov
added
the
PR: polish 💅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildExecutionContextused to throw an error on failure, but was changedto return an array of errors (enabling the function to return multiple
errors encountered during variable coercion).
As the function is no longer designed to throw, it no longer needs to be
wrapped in a try block when used within the
subscribefunction. Thischange aligns the use of
buildExecutionContext between thesubscribeandexecute` functions.