Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc examples to reflect the current API #3393

Merged
merged 1 commit into from Dec 1, 2021

Conversation

paulserraino
Copy link
Contributor

hello, I was trying out graphql-js today and noticed that the Readme documentation doesn't match the current object-based interface

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 29, 2021

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@IvanGoncharov IvanGoncharov merged commit 36f068e into graphql:main Dec 1, 2021
yaacovCR added a commit to yaacovCR/graphql-executor that referenced this pull request Dec 6, 2021
* execute: fix spec section names in comments (graphql#3376)

* lexer-tests: Use tildas as invalid characters (graphql#3377)

* Preserve non-error values thrown from resolvers (graphql#3384)

* Add support for Node17 (graphql#3386)

* Update package-lock.json (graphql#3387)

* Drop "eslint-plugin-istanbul" and implement as internal ESLint rule (graphql#3388)

* package.json: Drop unused '@babel/eslint-parser' (graphql#3389)

* Update deps (graphql#3390)

* Enable '@typescript-eslint/switch-exhaustiveness-check' rule (graphql#3391)

* Remove $FlowFixMe comments (graphql#3392)

* typeFromAST: use exhaustive switch and remove invariant (graphql#3396)

* Update doc examples to reflect the current API (graphql#3393)

* Switch coverage from nyc to c8 (graphql#3398)

* Update deps (graphql#3399)

* expectJSON: improve readability (graphql#3400)

* tests: Improve formating of strings with 'dedent' tag (graphql#3401)

* ci: add check that 'package-lock.json' doesn't have conflicts (graphql#3403)

* github/workflows: simplify npm cache setup (graphql#3404)

* Use for '--ignore-scripts' for all `npm ci` & `npm install` (graphql#3405)

* Simplify code by replacing Object.entries with Object.keys (graphql#3406)

* ci: add check for unnessary duplicates in package-lock.json (graphql#3407)

* update lockfile

* Fix ci merge

* fix package-lock file

...starting again from most current graphql-js

Co-authored-by: Alex Reilly <fabiobean2@gmail.com>
Co-authored-by: Ivan Goncharov <ivan.goncharov.ua@gmail.com>
Co-authored-by: Paul Serraino <pserraino99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants