Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validation-test.ts: various grammar fixes #3452

Merged
merged 6 commits into from Jan 10, 2022
Merged

validation-test.ts: various grammar fixes #3452

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
96025a1
Use singular in schema validation test description
spawnia Jan 9, 2022
d47b851
an -> a
spawnia Jan 9, 2022
0303565
it ...
spawnia Jan 9, 2022
9c3d307
combines multiple error
spawnia Jan 9, 2022
986e853
combines multiple errors
spawnia Jan 9, 2022
ebadc05
Merge remote-tracking branch 'origin/schema-validation-grammar' into …
spawnia Jan 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/type/__tests__/validation-test.ts
View file
Open in desktop
Expand Up @@ -1065,7 +1065,7 @@ describe('Type System: Object fields must have output types', () => {
});

describe('Type System: Objects can only implement unique interfaces', () => {
it('rejects an Object implementing a non-type values', () => {
it('rejects an Object implementing a non-type value', () => {
const schema = new GraphQLSchema({
query: new GraphQLObjectType({
name: 'BadObject',
Expand Down Expand Up @@ -1512,7 +1512,7 @@ describe('Type System: Arguments must have input types', () => {
]);
});

it('rejects an required argument that is deprecated', () => {
it('rejects a required argument that is deprecated', () => {
const schema = buildSchema(`
directive @BadDirective(
badArg: String! @deprecated
Expand Down Expand Up @@ -2610,7 +2610,7 @@ describe('Interfaces must adhere to Interface they implement', () => {
});

describe('assertValidSchema', () => {
it('do not throw on valid schemas', () => {
it('does not throw on valid schemas', () => {
const schema = buildSchema(`
type Query {
foo: String
Expand All @@ -2619,7 +2619,7 @@ describe('assertValidSchema', () => {
expect(() => assertValidSchema(schema)).to.not.throw();
});

it('include multiple errors into a description', () => {
it('combines multiple errors', () => {
const schema = buildSchema('type SomeType');
expect(() => assertValidSchema(schema)).to.throw(dedent`
Query root type must be provided.
Expand Down